Adopt esbuild for bundling more builtin extensions #294227
Draft
+114
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates three built-in extensions from webpack to esbuild for bundling: mermaid-chat-features, media-preview, and markdown-math. This follows the pattern established in PR #294208 which migrated the markdown-language-features extension.
Changes:
- Replaced webpack configurations with esbuild configurations for Node.js and browser builds
- Updated ESLint configuration to use more specific file patterns for the migrated extensions
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/mermaid-chat-features/extension-browser.webpack.config.js | Deleted webpack browser configuration (replaced by esbuild-browser.ts) |
| extensions/mermaid-chat-features/esbuild.ts | Added esbuild configuration for Node.js builds |
| extensions/mermaid-chat-features/esbuild-browser.ts | Added esbuild configuration for browser builds with process.* defines |
| extensions/media-preview/extension.webpack.config.js | Deleted webpack configuration (replaced by esbuild.ts) |
| extensions/media-preview/esbuild.ts | Added esbuild configuration for Node.js builds |
| extensions/media-preview/esbuild-browser.ts | Added esbuild configuration for browser builds with process.* defines |
| extensions/markdown-math/extension-browser.webpack.config.js | Deleted webpack browser configuration (replaced by esbuild-browser.ts) |
| extensions/markdown-math/esbuild.ts | Added esbuild configuration for Node.js builds |
| extensions/markdown-math/esbuild-browser.ts | Added esbuild configuration for browser builds with process.* defines |
| eslint.config.js | Updated file patterns from wildcards to specific paths for the migrated extensions |
Comments suppressed due to low confidence (1)
eslint.config.js:2071
- The glob pattern 'extensions/mermaid-chat-features/src/.ts' only matches TypeScript files directly in the src directory, but the extension has subdirectories like 'src/util/' with TypeScript files. This pattern should be 'extensions/mermaid-chat-features/src/**/.ts' to match all TypeScript files recursively.
'extensions/mermaid-chat-features/src/*.ts',
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #294208
Will let that PR cook a day or so before merging this in too. Also creating full build for testing