[playwright-browser-tunnel] Seperate out tunnelBrowserConnection and createTunneledBrowser to remove playwright dependency from tunnelBrowserConnection #5609
+145
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarmawala
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
TheLarkInn
requested changes
Feb 7, 2026
bmiddha
reviewed
Feb 7, 2026
Member
bmiddha
left a comment
bmiddha
left a comment
There was a problem hiding this comment.
What if you added the MCP wrapper here to start the MCP with the tunnel browser config?
...hanges/@rushstack/playwright-browser-tunnel/fix-update-dependency-chat_2026-02-07-01-52.json
Outdated
Show resolved
Hide resolved
Author
I think regardless, we should do this. I can look into this after this PR |
…-dependency-chat_2026-02-07-01-52.json Co-authored-by: Bharat Middha <5100938+bmiddha@users.noreply.github.com>
TheLarkInn
requested changes
Feb 10, 2026
Member
TheLarkInn
left a comment
TheLarkInn
left a comment
There was a problem hiding this comment.
Since this is a change intrinsically to the PLBS vscode-extension, we need to bump that package.json version and add it to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / Details
Seperate out the functions in the tunneledBrowserConnection since both functions don't require
playwright. Moving them to seperate files allows you to import them individually without importingplaywright.How it was tested
Using rush build as the api should remain the same but give additional ways to import.
Impacted documentation
N/A