Conversation
natoverse
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming Performance Improvement (with .txt):
run time: -60.70%
peak memory: -31.38%
memory delta: -11.58%
This pull request refactors the
create_final_documentsworkflow to use streaming table reads and writes instead of loading entire dataframes into memory. The main goal is to make the workflow more efficient and scalable by processing data in a streaming fashion. The changes also simplify the logic by removing the dependency on pandas and theDataReaderclass.Refactor to streaming table processing:
run_workflowfunction increate_final_documents.pyto use asynchronous context managers for opening tables and removed pandas DataFrame operations in favor of streaming row-by-row processing.create_final_documentsasync function that builds a mapping from text units to documents and enriches each document row with its associated text unit IDs as it streams through the data, writing results directly to the output table.Dependency and import changes:
DataReader, and added imports for the new row transformer and table abstractions.