fix(mcp): validate wallet addresses and restrict balance API to EVM#35
Open
Lutra23 wants to merge 1 commit intomicrochipgnu:mainfrom
Open
fix(mcp): validate wallet addresses and restrict balance API to EVM#35Lutra23 wants to merge 1 commit intomicrochipgnu:mainfrom
Lutra23 wants to merge 1 commit intomicrochipgnu:mainfrom
Conversation
|
@Lutra23 is attempting to deploy a commit to the Inventions Hub Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some API endpoints accept
walletAddressas non-empty text but do not validate format before using it in EVM flows. This can lead to dirty data and downstream runtime failures.This PR adds lightweight EVM address validation using existing
viemutilities and rejects invalid input early with400.Changes
apps/mcp/src/lib/validation/address.tsisValidEvmAddress()based onviem/isAddressisEvmNetwork()based on the network registry (architecture === 'evm')/api/onramp/urlwalletAddressas EVM address; return400if invalid/api/balance400whennetworkis not EVM (balance-tracker is EVM-only today)walletAddressas EVM address before calling balance-trackerBehavior change (expected)
Invalid addresses that previously passed “non-empty” checks will now be rejected with
400.