fix(mcp): enforce strict wallet network matching in CDP strategy#34
Open
Lutra23 wants to merge 1 commit intomicrochipgnu:mainfrom
Open
fix(mcp): enforce strict wallet network matching in CDP strategy#34Lutra23 wants to merge 1 commit intomicrochipgnu:mainfrom
Lutra23 wants to merge 1 commit intomicrochipgnu:mainfrom
Conversation
|
@Lutra23 is attempting to deploy a commit to the Inventions Hub Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CDPSigningStrategycurrently treats mainnet/testnet as compatible by “family” (e.g.baseandbase-sepolia) and also falls back to any active wallet when no compatible wallet is found. This blurs network domain separation for payment signing.This PR enforces strict matching:
walletNetwork === targetNetwork.Repro (before)
base-sepoliaCDP wallet active.base.Impact
Behavior change (expected)
This is a tightening change: flows that previously “worked by accident” via family/fallback may now return an error if no wallet exists on the target network.