Open
Conversation
iobuhov
force-pushed
the
3216/gallery-paging-and-autoselect
branch
3 times, most recently
from
ee916ba to
719c753
Compare
iobuhov
force-pushed
the
3216/gallery-paging-and-autoselect
branch
from
1492bce to
5b16988
Compare
iobuhov
force-pushed
the
3216/gallery-paging-and-autoselect
branch
from
38cf8bc to
db93377
Compare
r0b1n
reviewed
Feb 16, 2026
| } | ||
|
|
||
| function isAutoSelectEnabled(props: DatagridContainerProps): boolean { | ||
| return props.itemSelection?.type === "Multi" && props.autoSelect; |
Collaborator
There was a problem hiding this comment.
Why it is restricted to multi, I believe it should work for both.
r0b1n
reviewed
Feb 16, 2026
Comment on lines
+72
to
+75
| <property key="autoSelect" type="boolean" defaultValue="false"> | ||
| <caption>Auto select first item</caption> | ||
| <description>Automatically select the first item</description> | ||
| </property> |
Collaborator
There was a problem hiding this comment.
There is no hiding of autoSelect in Gallery.editorConfig when selection is set to None.
r0b1n
reviewed
Feb 16, 2026
| "dynamicPageSize", | ||
| "useCustomPagination", | ||
| "customPagination", | ||
| "totalCountValue" |
Collaborator
There was a problem hiding this comment.
I see that data grid is not hiding this attribute, not sure which way is the correct one.
r0b1n
reviewed
Feb 17, 2026
Comment on lines
+302
to
+306
| <span className="widget-gallery-selection-counter-text" aria-live="polite" aria-atomic="true"> | ||
| {props.selectedCountTemplateSingular} | ||
| </span> | ||
| | | ||
| <button className="widget-gallery-btn-link">{props.clearSelectionButtonLabel}</button> |
Collaborator
There was a problem hiding this comment.
Shouldn't this be widget-datagrid-* instead of widget-gallery-* ? Maybe use ${cls.root}-*.
r0b1n
reviewed
Feb 17, 2026
| {children} | ||
| </div> | ||
| ); | ||
| export function GalleryFooter({ children, className }: PropsWithChildren<{ className?: string }>): ReactElement { |
Collaborator
There was a problem hiding this comment.
Looks like no one is passing className prop, maybe it should go as well.
r0b1n
reviewed
Feb 17, 2026
Comment on lines
+24
to
+29
| const isSelected = computed( | ||
| () => { | ||
| return selectActions.isSelected(item); | ||
| }, | ||
| { name: "[gallery]:@computed:ListItem:isSelected" } | ||
| ).get(); |
Collaborator
There was a problem hiding this comment.
Is it alright to re-create it every time in render?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Refactoring (e.g. file rename, variable rename, etc.)
New feature (non-breaking change which adds functionality)
Description
Migrated features from data grid to gallery.
What should be covered while testing?