Open
Conversation
Per discussion in matplotlib/matplotlib#22601 (comment) this is actually breaking builds in subtle very brittle way as the links that will be generated will be pointing at the top-level files (that are actually re-directs to /stable). The second step of this will be to put a 301 redirect into caddy.
Member
|
We're actually serving from |
Member
Author
|
Changed the bass branch. From reading the ansible (~L95) where we do the checkouts all of the repos go to |
Member
|
Yea, they're currently in sync, so I was a bit lazy with writing the Ansible, but that's not what's currently being served. |
Member
Author
|
Given that the caddy configuration seems to be taking precedence anyway, this is a pretty low priority to get done (mostly to avoid confusing future us). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in
matplotlib/matplotlib#22601 (comment)
this is actually breaking builds in subtle very brittle way as the links that
will be generated will be pointing at the top-level files (that are actually
re-directs to /stable).
The second step of this will be to put a 301 redirect into caddy.