Adapt for localstack-standalone-cli

[silv-io]

Motivation

The pyinstaller build needs some changes to work with the new standalone cli. The old build referenced localstack_ext and localstack.pro.core modules that no longer exist in the new localstack_cli namespace.

Changes

• Change main.py entry point to import localstack_cli
• Update Makefile pyinstaller arguments to use localstack_cli
• Remove references to localstack_ext and localstack.pro.core
• Replace hooks/hook-localstack_core.py with hooks/hook-localstack.py

[alexrashed]

Thanks for jumping on this and updating this proactively! The pipeline is still red, and I think that's because with your changes you are dropping a hidden import that is necessary.

[alexrashed]

Nice, thanks for fixing the imports!

[alexrashed]

question: How do you plan to get rid of this exact pin here to make sure that this is using the proper version after the next release of localstack?

[silv-io]

I'll change the release pipeline in pro to publish the standalone cli + make the pyinstaller build depend on it.

For this change we'd have two options: revert this to 4.13.1, but then the build will fail on main, or keep this change until the actual next localstack release comes out.

[alexrashed]

But wouldn't this break the pipeline here in main after the merge of this PR?

[silv-io]

I've edited the message before I got your response. Is this a response to what I planned before (reverting) or to what I've changed it to?

[silv-io]

If it's to the new one, how would it break on main if we keep the PR as-is? 🤔

[alexrashed]

I am confused by your message edits to be honest. So will this PR be merged at the time of the release? If so how does this play in the grand scheme of our release action?

If the PR is merged now, are you okay with breaking main?

Up to you, just want to make sure you are aware of the consequences / have a plan. 😛

[silv-io]

I'll merge this now to match up with the latest dev release state of localstack. The next release will automatically change this to not be on the dev release anymore 👍🏼

[alexrashed]

Ah, perfect, thanks!