feat(litmus): add option to skip wait-for-mongodb initContainer (#469) #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add portal.server.waitForMongodb.enabled flag to allow users to skip the wait-for-mongodb initContainer when using external MongoDB that is already running. This resolves issues in air-gapped environments and reduces deployment time when MongoDB is already accessible. Signed-off-by: Said BOUDJELDA <bmscomp@gmail.com>
bmscomp
requested review from
Jasstkn,
Jonsy13,
Saranya-jena,
imrajdas and
ispeakc0de
as code owners
bmscomp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add portal.server.waitForMongodb.enabled flag to allow users to skip
the wait-for-mongodb initContainer when using external MongoDB that is
already running.
What this PR does / why we need it:
This resolves issues in air-gapped environments and reduces deployment
time when MongoDB is already accessible.
Which issue this PR fixes
Special notes for your reviewer:
@imrajdas @ispeakc0de @Jasstkn Need your feedback and guide for this PR, I do not know much the impact on the existing please let me know anything to enhance
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]