Port Lightbox and Flashspot to GObject#13586
Open
JosephMcc wants to merge 1 commit intolinuxmint:masterfrom
Open
Port Lightbox and Flashspot to GObject#13586JosephMcc wants to merge 1 commit intolinuxmint:masterfrom
JosephMcc wants to merge 1 commit intolinuxmint:masterfrom
Conversation
The port requires renaming the show/hide methods of the Lightbox object. Update several other things while at it. Use connectObject, clean up some clutter deprecations, and use better comparison operators. Lightbox isn't really used in any spices, so this shouldn't have any real effect on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The port requires renaming the show/hide methods of the Lightbox object. Update several other things while at it. Use connectObject, clean up some clutter deprecations, and use better comparison operators.
Lightbox isn't really used in any spices, so this shouldn't have any real effect on them.