fix: Add fastapi-app service to docker-compose.yml.#57
Open
maverickjit wants to merge 1 commit intokeploy:mainfrom
Open
fix: Add fastapi-app service to docker-compose.yml.#57maverickjit wants to merge 1 commit intokeploy:mainfrom
maverickjit wants to merge 1 commit intokeploy:mainfrom
Conversation
|
Hey @maverickjit, Thank you for raising the changes. Our team will review the changes soon before that please make sure to sign the DCO |
pratik-mahalle
left a comment
There was a problem hiding this comment.
Hi @maverickjit, The fast-app service is already added in the repo.
You can check that here https://github.com/keploy/samples-python/blob/main/fastapi-postgres/docker-compose.yml
I really appreciate your effort. For now, we are closing this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR fixes Issue #13 by adding the missing
fastapi-appservice to thedocker-compose.ymlfile under thefastapi-postgressample.Previously, the FastAPI container was not defined in
docker-compose.yml, which preventedkeploy recordfrom detecting the application for testing.🔧 Changes Made
fastapi-appservice tofastapi-postgres/docker-compose.ymlkeploy recordto work as expected with FastAPI✅ How I Tested
docker-compose upto start both FastAPI and Postgreskeploy record -c "docker-compose up" --container-name fastapi-appto capture test cases successfully📌 Related Issue
Fixes #13
Let me know if there are additional changes or test scenarios you'd like me to add. Happy to iterate!
