Skip to content

Implement cleanUpFilter method in SoftBloomFilter#2611

Merged
codex128 merged 2 commits intojMonkeyEngine:masterfrom
capdevon:capdevon-SoftBloomFilter
Feb 17, 2026
Merged

Implement cleanUpFilter method in SoftBloomFilter#2611
codex128 merged 2 commits intojMonkeyEngine:masterfrom
capdevon:capdevon-SoftBloomFilter

Conversation

@capdevon
Copy link
Contributor

Added cleanUpFilter method to properly clean up passes.

Added cleanUpFilter method to properly clean up passes.
@github-actions
Copy link

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

  • Go to the (failed run) > Summary > Artifacts > screenshot-test-report
  • Download the zip and open jme3-screenshot-tests/build/reports/ScreenshotDiffReport.html

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

@codex128 codex128 merged commit 48ce41b into jMonkeyEngine:master Feb 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments