Make result_type typedef in pcg_extras::seed_seq_from public#83
Open
timo-eichhorn wants to merge 3 commits intoimneme:masterfrom
Open
Make result_type typedef in pcg_extras::seed_seq_from public#83timo-eichhorn wants to merge 3 commits intoimneme:masterfrom
timo-eichhorn wants to merge 3 commits intoimneme:masterfrom
Conversation
Changed result_type typedef in pcg_extras::seed_seq_from to be public in order to be compatible with standard library PRNGs
|
Merged into Total-Random/pcg-cpp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless I'm somehow misunderstanding how
pcg_extras::seed_seq_fromis supposed to be used, I believe theresult_typetypedef inpcg_extras::seed_seq_fromshould be public instead of private. Otherwise, when trying to usepcg_extras::seed_seq_fromwith standard library PRNGs (saystd::mt19937), compilation fails (for both gcc 12.1.0 and clang 14.0.0) due to the aforementioned typedef being private.A simple example demonstrating the problem:
After the change, the program compiles without problems.