Skip to content

Fix continuous DiD tutorial formatting#180

Merged
igerber merged 1 commit intomainfrom
c-did-tutorial-fix
Feb 22, 2026
Merged

Fix continuous DiD tutorial formatting#180
igerber merged 1 commit intomainfrom
c-did-tutorial-fix

Conversation

@igerber
Copy link
Owner

@igerber igerber commented Feb 22, 2026

Summary

  • Escape dollar signs ($7, $11, $2) in cell 14 markdown to prevent Jupyter from rendering currency amounts as LaTeX
  • Split chart cell 27: remove print() statements after plt.show() and add a new markdown cell for the explanatory text

Methodology references (required if estimator / math changes)

  • N/A — no methodology changes (tutorial formatting only)

Validation

  • Tests added/updated: No test changes
  • Backtest / simulation / notebook evidence: Notebook executed end-to-end via nbconvert — all cells pass, outputs cleared

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

… chart cell

- Escape $7, $11, $2 as \$7, \$11, \$2 in cell 14 to prevent Jupyter
  LaTeX rendering of currency amounts
- Move explanatory print() text from chart cell 27 into a new markdown
  cell so prose doesn't mix into plot output

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

Overall Assessment: ✅ Looks good

Executive Summary

  • Formatting-only edits in docs/tutorials/14_continuous_did.ipynb (escaped $ in markdown and moved explanatory text to a markdown cell), no estimator logic or outputs changed.
  • Methodology registry cross-check not applicable because there are no changes to estimators, math, weighting, or inference.
  • No tests updated or required for this change set.

Methodology

  • Severity: P3 | Impact: None; tutorial markdown formatting only, no estimator or identification changes (docs/tutorials/14_continuous_did.ipynb:L299-L307, docs/tutorials/14_continuous_did.ipynb:L561-L574) | Concrete fix: None.

Code Quality

  • Severity: P3 | Impact: None; removal of print() after plt.show() in a notebook cell improves output cleanliness, no logic change (docs/tutorials/14_continuous_did.ipynb:L619-L637) | Concrete fix: None.

Performance

  • Severity: P3 | Impact: None; no runtime logic changes | Concrete fix: None.

Maintainability

  • Severity: P3 | Impact: None; explanatory text moved to markdown cell improves readability, no code impact (docs/tutorials/14_continuous_did.ipynb:L625-L641) | Concrete fix: None.

Tech Debt

  • Severity: P3 | Impact: None; no new debt introduced | Concrete fix: None.

Security

  • Severity: P3 | Impact: None; no secrets or sensitive data introduced | Concrete fix: None.

Documentation/Tests

  • Severity: P3 | Impact: None; docs-only change, tests not required | Concrete fix: None.

If you want a deeper pass (e.g., validating notebook execution metadata or output clearing), point me at the full notebook JSON and I’ll check it.

@igerber igerber merged commit 4d08773 into main Feb 22, 2026
1 check passed
@igerber igerber deleted the c-did-tutorial-fix branch February 22, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant