refactor(auth): better UX for OAuth error messages#479
Open
facundo-herodevs wants to merge 1 commit intomainfrom
Open
refactor(auth): better UX for OAuth error messages#479facundo-herodevs wants to merge 1 commit intomainfrom
facundo-herodevs wants to merge 1 commit intomainfrom
Conversation
facundo-herodevs
force-pushed
the
fr/oauth-error-messages
branch
from
7354590 to
576d648
Compare
KLongmuirHD
reviewed
Feb 23, 2026
src/commands/auth/login.ts
Outdated
| oauthError, | ||
| oauthErrorDescription ?? 'no description', | ||
| ); | ||
| const browserMessage = isAlreadyLoggedIn |
Contributor
There was a problem hiding this comment.
suggestion: nested ternaries aren't very readable. standard if block is better here
facundo-herodevs
force-pushed
the
fr/oauth-error-messages
branch
from
576d648 to
be2e45d
Compare
facundo-herodevs
force-pushed
the
fr/oauth-error-messages
branch
from
be2e45d to
baa715b
Compare
v3nant
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.