feat(cli): unify Amplitude identify flow and enforce cli event source#478
Open
facundo-herodevs wants to merge 1 commit intomainfrom
Open
feat(cli): unify Amplitude identify flow and enforce cli event source#478facundo-herodevs wants to merge 1 commit intomainfrom
facundo-herodevs wants to merge 1 commit intomainfrom
Conversation
92fc0a5 to
7492d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens CLI Amplitude identity handling so event ordering is deterministic, identity claims are mapped from canonical token fields, and JWT decoding logic is shared instead of duplicated.
What Changed
Analytics initialization and event ordering
await initializeAnalytics()before sendingCLI Command Submitted.Identity resolution from auth tokens
refreshIdentityFromStoredToken().user_idfromsubemailfromemailorganization_namefromcompanyrolefromroleShared JWT payload decoder
src/service/jwt.svc.tswithdecodeJwtPayload(token)for safe payload parsing.src/service/analytics.svc.tsfor identity extractionsrc/service/auth-token.svc.tsfor access-token expiry checksIdentify behavior (dedupe + metadata)
device_id,session_id,platform,os_name,os_version,app_versionTracking contract hardening
source=clifor all tracked events.Identify Callis emitted withsource=cliand event options includinguser_idwhen available.Login flow integration
auth login, the command now callsrefreshIdentityFromStoredToken()to bind analytics identity immediately for post-login telemetry.Issue: https://github.com/neverendingsupport/data-and-integrations/issues/573