chore: librarian generate pull request: 20260226T204943Z#1301
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Google Cloud Bigtable Admin client library to incorporate new features related to tiered storage configuration. It introduces new message types for defining tiered storage rules and integrates them into the existing table administration capabilities. Additionally, it includes maintenance updates to the Python testing environment and dependencies, reflecting standard library generation processes. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the noxfile.py to remove Python 3.9 support for testing and introduces the cryptography dependency. It also includes generated code changes to incorporate TieredStorageConfig and TieredStorageRule types into the Bigtable Admin API, reflecting new features from the underlying proto definitions. The state.yaml file has been updated to reflect the latest generated commit.
| UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {} | ||
|
|
||
| SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.9", "3.14"] | ||
| SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.10", "3.14"] |
There was a problem hiding this comment.
|
|
||
| # 'docfx' is excluded since it only needs to run in 'docs-presubmit' | ||
| nox.options.sessions = [ | ||
| "unit-3.9", |
There was a problem hiding this comment.
| # Remaining dependencies | ||
| other_deps = [ | ||
| "requests", | ||
| "cryptography", |
There was a problem hiding this comment.
A new dependency, cryptography, has been added. For better dependency management and to prevent unexpected issues from future breaking changes, it is recommended to pin new dependencies to a specific version or a version range (e.g., cryptography>=X.Y,<X.Z). Please consider adding a version constraint.
| "cryptography", | |
| "cryptography>=41.0.0", |
|
The system test and prerelease failures are unrelated. |
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: add TieredStorageConfig to table admin api
PiperOrigin-RevId: 863493708
Library-IDs: google-cloud-bigtable
Source-link: googleapis/googleapis@a6cbf809
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@a17b84ad
(exclusive) and
googleapis/googleapis@a6cbf809
(inclusive).
Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209