Skip to content

chore: librarian generate pull request: 20260226T204943Z#1301

Merged
parthea merged 2 commits intomainfrom
librarian-20260226T204943Z
Feb 26, 2026
Merged

chore: librarian generate pull request: 20260226T204943Z#1301
parthea merged 2 commits intomainfrom
librarian-20260226T204943Z

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Feb 26, 2026

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
feat: add TieredStorageConfig to table admin api

PiperOrigin-RevId: 863493708
Library-IDs: google-cloud-bigtable
Source-link: googleapis/googleapis@a6cbf809
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@a17b84ad
(exclusive) and
googleapis/googleapis@a6cbf809
(inclusive).

Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209

@parthea parthea requested a review from a team as a code owner February 26, 2026 20:49
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. labels Feb 26, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Google Cloud Bigtable Admin client library to incorporate new features related to tiered storage configuration. It introduces new message types for defining tiered storage rules and integrates them into the existing table administration capabilities. Additionally, it includes maintenance updates to the Python testing environment and dependencies, reflecting standard library generation processes.

Highlights

  • Bigtable Admin API Update: Added TieredStorageConfig and TieredStorageRule to the Bigtable Admin API, enabling configuration of tiered storage for tables.
  • Python Test Environment Updates: Updated the noxfile.py to use Python 3.10 for system tests, removed Python 3.9 unit tests, and added cryptography as a dependency for prerelease environments.
  • Automated Client Library Generation: Updated the last_generated_commit in the librarian state, indicating a routine update of the google-cloud-bigtable client library based on recent proto changes.
Changelog
  • .librarian/generator-input/noxfile.py
    • Updated SYSTEM_TEST_PYTHON_VERSIONS to include Python 3.10 instead of 3.9 for system tests.
    • Removed 'unit-3.9' from the default nox.options.sessions list.
    • Added 'cryptography' to the list of other_deps for prerelease environments.
  • .librarian/state.yaml
    • Updated the last_generated_commit hash for the google-cloud-bigtable library.
  • google/cloud/bigtable_admin/init.py
    • Imported TieredStorageConfig and TieredStorageRule from google.cloud.bigtable_admin_v2.types.table.
    • Added TieredStorageConfig and TieredStorageRule to the module's __all__ export list.
  • google/cloud/bigtable_admin_v2/init.py
    • Imported TieredStorageConfig and TieredStorageRule from .types.table.
    • Added TieredStorageConfig and TieredStorageRule to the module's __all__ export list.
  • google/cloud/bigtable_admin_v2/types/init.py
    • Imported TieredStorageConfig and TieredStorageRule from table.
    • Added TieredStorageConfig and TieredStorageRule to the module's __all__ export list.
  • google/cloud/bigtable_admin_v2/types/table.py
    • Added TieredStorageConfig and TieredStorageRule to the Table message's _pb enum.
    • Introduced a new tiered_storage_config field to the Table message.
    • Defined the new TieredStorageConfig proto message, including an infrequent_access field.
    • Defined the new TieredStorageRule proto message, including an include_if_older_than field.
Activity
  • This pull request was automatically created by the Librarian CLI to generate Cloud Client Libraries code from updated protos.
  • The changes include a nested commit adding TieredStorageConfig to the Bigtable Admin API, sourced from googleapis/googleapis@a6cbf809.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the noxfile.py to remove Python 3.9 support for testing and introduces the cryptography dependency. It also includes generated code changes to incorporate TieredStorageConfig and TieredStorageRule types into the Bigtable Admin API, reflecting new features from the underlying proto definitions. The state.yaml file has been updated to reflect the latest generated commit.

UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {}

SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.9", "3.14"]
SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.10", "3.14"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The SYSTEM_TEST_PYTHON_VERSIONS has been updated to remove Python 3.9. This indicates a change in the supported Python versions for system tests. Please ensure this change is intentional and that users are informed about the updated Python version requirements for running system tests.


# 'docfx' is excluded since it only needs to run in 'docs-presubmit'
nox.options.sessions = [
"unit-3.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The unit-3.9 session has been removed from the nox.options.sessions list. This change aligns with the removal of Python 3.9 from the system test versions. Please confirm this is the intended behavior and that any implications for unit testing on Python 3.9 are understood.

# Remaining dependencies
other_deps = [
"requests",
"cryptography",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

A new dependency, cryptography, has been added. For better dependency management and to prevent unexpected issues from future breaking changes, it is recommended to pin new dependencies to a specific version or a version range (e.g., cryptography>=X.Y,<X.Z). Please consider adding a version constraint.

Suggested change
"cryptography",
"cryptography>=41.0.0",

@parthea
Copy link
Contributor Author

parthea commented Feb 26, 2026

The system test and prerelease failures are unrelated. Insufficient node quota

@parthea parthea merged commit c3ea54e into main Feb 26, 2026
31 of 34 checks passed
@parthea parthea deleted the librarian-20260226T204943Z branch February 26, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants