-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian generate pull request: 20260211T172749Z #15560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates significant enhancements to the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by the Librarian CLI, introduces several new features to the Discovery Engine client library, primarily related to Natural Language Query Understanding (NLQ), search result crowding, and semantic search state reporting. The changes include new fields in request and response messages, new message types, and updated documentation. The corresponding unit tests have also been updated to cover these new features.
The changes are mostly auto-generated and look correct. I've found one minor formatting issue in a docstring which I've commented on. Otherwise, the changes are good to go.
| \`Graphics Cards > RTX_4090 | ||
|
|
||
| Founders Edition\` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a formatting issue in the example for page_categories. The backslash \ seems to be a typo for a backtick `, and the example is split across multiple lines with incorrect indentation. This makes the example hard to read and understand. For clarity and consistency with other examples in this file, it should be a single-line code block using double backticks.
| \`Graphics Cards > RTX_4090 | |
| Founders Edition\` | |
| ``Graphics Cards > RTX_4090 > Founders Edition`` |
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: add output-only field SemanticState to SearchResponse.
PiperOrigin-RevId: 868345232
Library-IDs: google-cloud-discoveryengine
Source-link: googleapis/googleapis@56bc1b49
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: update documentation for search and data store NLQ features
PiperOrigin-RevId: 868345232
Library-IDs: google-cloud-discoveryengine
Source-link: googleapis/googleapis@56bc1b49
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: other misc documentation updates
Clients can specify Natural Language Query Understanding-related fields, as well as CrowdingSpec. These features are available in the V1 APIs.
PiperOrigin-RevId: 868345232
Library-IDs: google-cloud-discoveryengine
Source-link: googleapis/googleapis@56bc1b49
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add Natural Language Query Understanding fields and messages to DiscoveryEngine request, response, and datastore messages
PiperOrigin-RevId: 868345232
Library-IDs: google-cloud-discoveryengine
Source-link: googleapis/googleapis@56bc1b49
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add CrowdingSpec to SearchRequest to set crowding settings
PiperOrigin-RevId: 868345232
Library-IDs: google-cloud-discoveryengine
Source-link: googleapis/googleapis@56bc1b49
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@c288189b
(exclusive) and
googleapis/googleapis@56bc1b49
(inclusive).
Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:f5426423676c75008c2135037e7b98f78cbb99f78b3c46fe043b6897be92d836