feat: Add getProjectId getter for ComputeEngineCredentials#1833
Open
psx95 wants to merge 3 commits intogoogleapis:mainfrom
Open
feat: Add getProjectId getter for ComputeEngineCredentials#1833psx95 wants to merge 3 commits intogoogleapis:mainfrom
psx95 wants to merge 3 commits intogoogleapis:mainfrom
Conversation
psx95
force-pushed
the
project-id-gce
branch
2 times, most recently
from
06dcbb3 to
f8ef6e5
Compare
psx95
force-pushed
the
project-id-gce
branch
from
1f831f0 to
fad6380
Compare
psx95
force-pushed
the
project-id-gce
branch
from
fad6380 to
aa762e4
Compare
dashpole
approved these changes
Feb 25, 2026
lqiu96
reviewed
Feb 25, 2026
Comment on lines
+367
to
+369
| synchronized (this) { | ||
| this.projectId = projectIdFromMetadata; | ||
| } |
Member
There was a problem hiding this comment.
Can we add a check that we only set this if projectIdFromMetadata is not null.
I think one small possibility is is that if there are multiple getProjectId() calls at the same time and all but the last one work. Last one errors out and resets this to null.
I don't think we need to worry about trying to ensure that only one projectId call ever goes.
lqiu96
approved these changes
Feb 25, 2026
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a project ID getter for
ComputeEngineCredentials.This is a follow-up to work done in #1813