fix: Improve prerelease version filtering and terminal detection#1365
Open
hobostay wants to merge 1 commit intogithub:mainfrom
Open
fix: Improve prerelease version filtering and terminal detection#1365hobostay wants to merge 1 commit intogithub:mainfrom
hobostay wants to merge 1 commit intogithub:mainfrom
Conversation
This commit fixes two issues in the installation script:
1. Fix prerelease tag filtering
- Previous behavior: Used `tail -1` which could return any tag (stable or prerelease)
- New behavior: Filters for tags containing '-' which indicate prerelease versions
(e.g., v1.0.0-beta, v1.0.0-alpha, etc.)
- Uses `grep -E '\-.*refs/tags/'` to filter for prerelease patterns
- Ensures `VERSION="prerelease"` actually installs a prerelease version
2. Remove redundant terminal detection
- Previous behavior: Checked `[ -t 0 ] || [ -e /dev/tty ]`
- The `[ -e /dev/tty ]` check tests if /dev/tty exists, not if stdin is a terminal
- This is redundant and could cause issues in some environments
- New behavior: Only use `[ -t 0 ]` which correctly checks if stdin is a TTY
These changes improve the reliability of the installation script,
especially when installing prerelease versions.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues in the installation script (
install.sh):Issues Fixed
1. Prerelease Tag Filtering
Problem: When
VERSION="prerelease"was specified, the script usedtail -1to get the last tag from git ls-remote, but this could return any tag (stable or prerelease), not specifically a prerelease version.Why this is problematic:
v1.0.0), the script would install it even though the user requested a prereleaseSolution: Filter for tags containing
-(which indicates prerelease versions likev1.0.0-beta,v1.0.0-alpha, etc.):This ensures that
VERSION="prerelease"always installs an actual prerelease version.2. Terminal Detection
Problem: The script checked
[ -t 0 ] || [ -e /dev/tty ]to determine if running interactively.Why this is problematic:
[ -t 0 ]correctly checks if file descriptor 0 (stdin) is a terminal[ -e /dev/tty ]only checks if the/dev/ttydevice file exists, not if stdin is connected to itSolution: Use only
[ -t 0 ]which is the correct and standard way to check for terminal interactivity:Impact
Test plan
[ -t 0 ]check🤖 Generated with Claude Code