Rust: Add telemtry tags to queries#21303
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts metadata on several Rust “summary” metric queries so they’re additionally tagged as telemetry, which (per the PR description) reduces what appears in the end-of-scan summary table.
Changes:
- Add the
telemetrytag torust/summary/summary-statistics. - Add the
telemetrytag torust/summary/reduced-summary-statistics. - Add the
telemetrytag torust/summary/query-sink-countsandrust/summary/nodes-at-type-path-length-limit.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/src/queries/summary/SummaryStatsReduced.ql | Adds telemetry to the query tags. |
| rust/ql/src/queries/summary/SummaryStats.ql | Adds telemetry to the query tags. |
| rust/ql/src/queries/summary/QuerySinkCounts.ql | Adds telemetry to the query tags. |
| rust/ql/src/queries/summary/NodesWithTypeAtLengthLimit.ql | Adds telemetry to the query tags. |
geoffw0
left a comment
There was a problem hiding this comment.
What you show in the PR description looks good. I won't pretend to know for sure all the possibly effects of this tag, the query metadata doc page doesn't shed any light, I suggest we go ahead with the change and just keep an eye on things after it is merged.
| * @kind metric | ||
| * @id rust/summary/summary-statistics | ||
| * @tags summary | ||
| * @tags summary telemetry |
There was a problem hiding this comment.
Could we do the same change to the Swift versions of these queries (that I am generally responsible for) - swift/summary/summary-statistics and swift/summary/query-sinks at least.
There was a problem hiding this comment.
I think I would prefer doing that on a separate PR.
Before this PR, each scan would end with a summary like
Now, it instead ends with
I don't think the removed rows provide any relevant information, hence this PR. I'm unsure, though, whether this will break something in the tool status page?