Skip to content

feat: Implement the GPU Info gathering within the Native SDK #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mujacica wants to merge 53 commits into
base: master
Choose a base branch
from
Open

feat: Implement the GPU Info gathering within the Native SDK #1336

mujacica wants to merge 53 commits into from
+1,411 −33

Conversation

@mujacica
Copy link
Contributor

@mujacica mujacica commented Aug 11, 2025 •
edited
Loading

  • Implement GPU Info Context for Native SDK
  • Support for Mac/Windows/Unix (Vulkan, Dynamically loaded)
  • Support for several Vendors
  • Added SENTRY_WITH_GPU_INFO option, ON by default on supported platforms
  • Include vulkan-headers as submodule

@github-actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 06e0f7c

bruno-garcia
bruno-garcia reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed things but seems great so far!

@mujacica mujacica marked this pull request as ready for review October 2, 2025 13:22
cursor[bot]

This comment was marked as outdated.

Sign in to view

@bruno-garcia
Copy link
Member

bruno-garcia commented Oct 2, 2025

@sentry review

seer-by-sentry[bot]
seer-by-sentry bot reviewed Oct 2, 2025
View reviewed changes
supervacuus
supervacuus reviewed Oct 7, 2025
View reviewed changes
supervacuus
supervacuus requested changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow my review message got lost... this looks great. Only minor topics that can be "fixed" or clarified.

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@mujacica mujacica requested a review from supervacuus October 9, 2025 11:06
JoshuaMoelans
JoshuaMoelans reviewed Oct 9, 2025
View reviewed changes
cursor[bot]

This comment was marked as outdated.

Sign in to view

mujacica and others added 28 commits February 11, 2026 09:52
@mujacica
Fix file format
a0fe5f5
@mujacica
Fix None implementation
f6c415f
@mujacica
Don't use singleton
889a124
@mujacica
Fix format
2e99fe2
@mujacica
Simplify driver version, remove test script
e40d3f4
@mujacica
Use Vulkan headers, dynamically load
3d4aaa7
@mujacica
Fix format
906b522
@mujacica
Fix CMake to include headers only
01a60dc
@mujacica
Fix 32-bit builds
8532078
@mujacica
Fix GPU test pritnf formats
0596e66
@mujacica
Fix format
d7a54bc
@mujacica
One more test fix
5d4a440
@mujacica
Fix format
7861d9f
@mujacica
Fix cursor comment
dd4ba8f
@mujacica @supervacuus
Update src/gpu/sentry_gpu_vulkan.c
bc60ed1 
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
@mujacica @supervacuus
Update src/gpu/sentry_gpu_vulkan.c
294d9c5 
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
@mujacica @supervacuus
Update tests/unit/test_gpu.c
81d0cc9 
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
@mujacica @supervacuus
Update README.md
1a102cc 
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
@mujacica
Fix PR Comments
a497edd
@mujacica @supervacuus
Update tests/unit/test_gpu.c
b6f0b8c 
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
@mujacica
Further fixes
33c6a57
@mujacica
Fix memory units
a9736a9
@mujacica
Fix docs
a44c5e8
@mujacica
Fix more comments
95e7ae5
@mujacica
Fix Mac compatibility
e202fee
@mujacica
Fix Vendor ID's
6da0996
@mujacica
Fix memory size to MB
2bc5e9d
@mujacica
Fix CHANGELOG
06e0f7c
cursor[bot]
cursor bot reviewed Feb 11, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@JoshuaMoelans JoshuaMoelans JoshuaMoelans left review comments

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@supervacuus supervacuus supervacuus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mujacica @bruno-garcia @supervacuus @JoshuaMoelans