feat(metrics): initialise MULTIPLEXED_METRIC_ROUTING_KEY for routing by harshit078 · Pull Request #19096 · getsentry/sentry-javascript

harshit078 · 2026-01-29T20:35:49Z

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes #18913

What changed

implemented attribute-based routing for metrics
added MetricRoutingInfo with dsn and release as its field
added routing to MetricOptions and enabled captureMetric to inject routing info into attributes
similarly added routing to InternalCaptureMetricOptions
created _stripRoutingAttributes function which removes routing info before sending to sentry

packages/core/src/metrics/internal.ts

packages/core/test/lib/transports/multiplexed.test.ts

packages/core/src/transports/multiplexed.ts

packages/core/src/metrics/internal.ts

harshit078 · 2026-02-03T11:37:04Z

Hi @chargome, the PR is ready to review. Thanks !

packages/core/src/transports/multiplexed.ts

packages/core/src/index.ts

chargome

Nice, thanks for opening the PR! I left some comments. Also, we definitely want to test this behaviour somehow in a browser integration test.

packages/core/src/transports/multiplexed.ts

chargome · 2026-02-04T11:40:40Z

packages/core/src/transports/multiplexed.ts

+      const container = Array.isArray(item) ? (item[1] as SerializedMetricContainer) : undefined;
+      const containerItems = container?.items;
+      if (containerItems) {
+        metric = containerItems[0];


Wouldn't this mean we always just pull the first metric?

yes it would mean we pull the first metric. What I'm thinking now after your comment is that I can add a logic which will check if all metrics and route to same or multiple destinations. Whats your opinion ?

packages/core/src/transports/multiplexed.ts

packages/core/src/index.ts

packages/core/src/metrics/public-api.ts

.size-limit.js

packages/core/src/transports/multiplexed.ts

packages/core/src/index.ts

packages/core/src/types-hoist/metric.ts

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

packages/browser/src/index.ts

packages/core/src/transports/multiplexed.ts

andreiborza · 2026-02-16T10:47:37Z

Unrelated to this PR, I sent you an email @harshit078. Let me know if you have any questions about it.

harshit078 · 2026-02-16T12:51:07Z

Hey @andreiborza , I got the email sent by you and I just replied back to it ;)

harshit078 and others added 13 commits January 30, 2026 02:05

feat(metrics): initialise MULTIPLEXED_METRIC_ROUTING_KEY for routing

97bafa8

Merge branch 'develop' into routing-to-different-dsn

ab12a06

Merge branch 'develop' into routing-to-different-dsn

b77918f

fix(metrics): resolve linting errors

9b635b1

Merge branch 'develop' into routing-to-different-dsn

a7632a9

Merge branch 'develop' into routing-to-different-dsn

37d54c2

fix(metrics): updated build files and added striping logic

00f559f

fix(metrics): linting errors

c2faff6

fix(metrics): add tests for multiplex

8a82bfd

fix(metrics): fix failing core eslint tests

d989887

Merge branch 'develop' into routing-to-different-dsn

d9854cb

fix(metrics): fix failing tests

f845c7b

fix(metrics): updated limit for failing size test

1c836c5

harshit078 marked this pull request as ready for review February 2, 2026 12:05

sentry bot reviewed Feb 2, 2026

View reviewed changes

packages/core/src/metrics/internal.ts Outdated Show resolved Hide resolved

cursor bot reviewed Feb 2, 2026

View reviewed changes

packages/core/src/metrics/internal.ts Outdated Show resolved Hide resolved

packages/core/test/lib/transports/multiplexed.test.ts Show resolved Hide resolved

packages/core/src/transports/multiplexed.ts Outdated Show resolved Hide resolved

harshit078 and others added 2 commits February 3, 2026 16:39

fix(metrics): address comments left by cursor and sentry

350f662

Merge branch 'develop' into routing-to-different-dsn

d38b5f5

cursor bot reviewed Feb 3, 2026

View reviewed changes

packages/core/src/transports/multiplexed.ts Show resolved Hide resolved

packages/core/src/metrics/internal.ts Outdated Show resolved Hide resolved

fix(metrics): address comments

cb71961

cursor bot reviewed Feb 3, 2026

View reviewed changes

packages/core/src/transports/multiplexed.ts Show resolved Hide resolved

harshit078 and others added 2 commits February 3, 2026 18:56

fix(metrics): address comments by cursor for race conditions

222973e

Merge branch 'develop' into routing-to-different-dsn

6baf564

cursor bot reviewed Feb 3, 2026

View reviewed changes

packages/core/src/transports/multiplexed.ts Show resolved Hide resolved

packages/core/src/transports/multiplexed.ts Show resolved Hide resolved

Lms24 requested a review from chargome February 4, 2026 09:05

Merge branch 'develop' into routing-to-different-dsn

33c0d25

cursor bot reviewed Feb 4, 2026

View reviewed changes

packages/core/src/index.ts Outdated Show resolved Hide resolved

chargome reviewed Feb 4, 2026

View reviewed changes

Merge branch 'develop' into routing-to-different-dsn

23800bf

sentry bot reviewed Feb 4, 2026

View reviewed changes

packages/core/src/metrics/public-api.ts Show resolved Hide resolved

cursor bot reviewed Feb 4, 2026

View reviewed changes

.size-limit.js Outdated Show resolved Hide resolved

harshit078 and others added 2 commits February 5, 2026 17:12

fix(metrics): address comments

b861ed2

Merge branch 'develop' into routing-to-different-dsn

e95310b

sentry bot reviewed Feb 5, 2026

View reviewed changes

packages/core/src/transports/multiplexed.ts Show resolved Hide resolved

cursor bot reviewed Feb 5, 2026

View reviewed changes

packages/core/src/transports/multiplexed.ts Show resolved Hide resolved

packages/core/src/index.ts Outdated Show resolved Hide resolved

harshit078 and others added 3 commits February 6, 2026 15:47

Merge branch 'develop' into routing-to-different-dsn

35c776a

fix(metrics): address comments and fix tests

58fccc9

fix(metrics): linting test

cf7811c

cursor bot reviewed Feb 6, 2026

View reviewed changes

packages/core/src/types-hoist/metric.ts Show resolved Hide resolved

harshit078 requested a review from chargome February 6, 2026 12:50

Merge branch 'develop' into routing-to-different-dsn

a41729a

cursor bot reviewed Feb 10, 2026

View reviewed changes

packages/browser/src/index.ts Show resolved Hide resolved

chargome self-assigned this Feb 12, 2026

harshit078 added 2 commits February 12, 2026 20:24

Merge branch 'develop' into routing-to-different-dsn

5f1fab4

Merge branch 'develop' into routing-to-different-dsn

fdccbd9

sentry bot reviewed Feb 15, 2026

View reviewed changes

packages/core/src/transports/multiplexed.ts Show resolved Hide resolved

Uh oh!

Comments

Conversation

harshit078 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harshit078 commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chargome left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chargome Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

harshit078 Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

andreiborza commented Feb 16, 2026

Uh oh!

harshit078 commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

harshit078 commented Jan 29, 2026 •

edited

Loading