Conversation
logaretm
changed the title
pino<9.10 supportpino<9.10 support
logaretm
added
Meta: Breaking
Package: node
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Contributor
size-limit report 📦
|
3 tasks
logaretm
force-pushed
the
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
branch
from
3d7aa48 to
e0577ed
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.
Changes:
- Removed
@apm-js-collab/tracing-hooksand@apm-js-collab/code-transformerdependencies - Deleted the injection loader infrastructure (
injectLoader.tsand related hooks) - Updated Pino integration to use only the native
pino_asJsontracing channel - Updated test dependencies to use Pino 9.10.0
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removed @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0 |
| packages/node-core/src/sdk/injectLoader.ts | Deleted entire file containing injection loader infrastructure |
| packages/node-core/src/sdk/index.ts | Removed GLOBAL_OBJ import and call to inject loader hook registration |
| packages/node-core/src/integrations/pino.ts | Removed addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10 |
| packages/node-core/package.json | Removed @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency |
| packages/core/src/utils/worldwide.ts | Removed _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions |
| dev-packages/node-integration-tests/package.json | Updated pino version from 9.9.4 to 9.10.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
s1gr1d
approved these changes
Feb 16, 2026
timfish
approved these changes
Feb 16, 2026
Lms24
approved these changes
Feb 16, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:
- I'd re-classify this as a fix and highlight it as an important change in the changelog
- Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).
Lms24
reviewed
Feb 16, 2026
|
|
||
| addExceptionMechanism(event, { | ||
| handled: options.error.handled, | ||
| type: 'pino', |
Member
There was a problem hiding this comment.
l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?
I'd suggest
Suggested change
| type: 'auto.log.pino', |
Member
Author
There was a problem hiding this comment.
Will create another PR 👍
logaretm
force-pushed
the
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
branch
from
e0577ed to
9ec85d9
Compare
logaretm
changed the title
pino<9.10 support
logaretm
force-pushed
the
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
branch
from
a7c1a31 to
bd1c6cd
Compare
logaretm
force-pushed
the
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
branch
from
bd1c6cd to
17cec6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.
We can drop support for older versions of Pino, given that
pino@9.10already exposes a tracing channel that we use, and that the injected channel was a backup forpino<9.10This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.
I will remove
@apm-js-collab/tracing-hooksas a dep fromnode-coresince nothing else uses it.closes #18199