Skip to content

Comments

feat: Made ManifestMetaDataReader read the DIST#5107

Open
bitsandfoxes wants to merge 2 commits intomainfrom
feat/manifest-read-dist
Open

feat: Made ManifestMetaDataReader read the DIST#5107
bitsandfoxes wants to merge 2 commits intomainfrom
feat/manifest-read-dist

Conversation

@bitsandfoxes
Copy link
Contributor

📜 Description

The ManifestMetaDataReader reads a lot of things, but not DIST. But the DIST can be provided through the options. Now if the Sentry SDK for Unity would want to share its DIST with the Android layer, it cannot do so if it sets up auto-initialization.

💡 Motivation and Context

Why is this change required?
Because the ManifestMetaDataReader did not read DIST - until now.

What problem does it solve?
It solves the problem of the ManifestMetaDataReader not reading the DIST.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Release!

@bitsandfoxes bitsandfoxes changed the title feat: ManifestMetaDataReader reads DIST feat: Made ManifestMetaDataReader read the DIST Feb 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Made ManifestMetaDataReader read the DIST by bitsandfoxes in #5107

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5553642

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 464.10 ms 546.84 ms 82.74 ms
Size 1.58 MiB 2.29 MiB 719.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d15471f 315.61 ms 360.22 ms 44.61 ms
6edfca2 314.02 ms 383.20 ms 69.18 ms
d217708 375.27 ms 415.68 ms 40.41 ms
a5ab36f 320.47 ms 389.77 ms 69.30 ms
d217708 355.34 ms 381.39 ms 26.05 ms
319f256 317.53 ms 370.83 ms 53.29 ms
6405ec5 310.88 ms 354.56 ms 43.69 ms
ce0a49e 532.00 ms 609.96 ms 77.96 ms
dba088c 365.46 ms 366.31 ms 0.85 ms
889ecea 367.58 ms 437.52 ms 69.94 ms

App size

Revision Plain With Sentry Diff
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
6edfca2 1.58 MiB 2.13 MiB 559.07 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
a5ab36f 1.58 MiB 2.12 MiB 555.26 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
319f256 1.58 MiB 2.19 MiB 619.79 KiB
6405ec5 1.58 MiB 2.12 MiB 552.23 KiB
ce0a49e 1.58 MiB 2.10 MiB 532.94 KiB
dba088c 1.58 MiB 2.13 MiB 558.99 KiB
889ecea 1.58 MiB 2.11 MiB 539.75 KiB

Previous results on branch: feat/manifest-read-dist

Startup times

Revision Plain With Sentry Diff
f699980 323.11 ms 404.30 ms 81.19 ms

App size

Revision Plain With Sentry Diff
f699980 1.58 MiB 2.29 MiB 719.77 KiB

@@ -4,6 +4,7 @@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 8.33.0.
    Consider moving the entry to the ## Unreleased section, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant