-
Notifications
You must be signed in to change notification settings - Fork 783
Added instructions how to trigger vuln processing with infra. #39612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
WalkthroughAdds a new section to the vulnerability processing documentation describing manual triggers for external vulnerability processing when scheduling is disabled. Includes step-by-step instructions for Kubernetes and AWS ECS deployments along with relevant configuration details. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for manually triggering vulnerability processing when using external/dedicated vulnerability processing infrastructure. This addresses issue #35239 where fleetctl trigger --name=vulnerabilities is not available when FLEET_VULNERABILITIES_DISABLE_SCHEDULE=true.
Changes:
- Added documentation section "Manually triggering vulnerability processing" to the vulnerability processing article
- Provided instructions for Kubernetes environments using
kubectl create job - Provided instructions for AWS ECS environments using
aws ecs run-task
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@rfairburn Can you check if the infra instructions I added to this guide are accurate? |
|
We actually don't use one-off tasks currently for vuln-processing in our terraform but rather a single long-running container that is the only one that can run the vuln-processing and is-not registered to the ALB at all. This does unfortunately make triggering the vuln scan by fleetctl or by manually running an ECS task impossible as-is. You can see the permanent service in the external vuln scans here. Originally we had intended to run the vuln scans as trigger-able by ECS run-task as you describe, but there was some reason that we ended up not doing so -- potentially undesired concurrency or some other reason -- that occured when we were first putting this together ~3 years ago that I cannot recall. I'm willing to revisit this going forward, but this is the state of things as they stand right now. It might be possible to scale the service to 0 and then |
Related issue: Resolves #35239
Documentation changes only for triggering vuln processing. These are useful for on-prem customers and dev/contributor/loadtest environments.
Summary by CodeRabbit