Skip to content

Add correct answer % and sent_at columns to approved puzzles table #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
etagwerker wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add correct answer % and sent_at columns to approved puzzles table #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1eec7f
Add correct answer % and sent_at columns to approved puzzles table
etagwerker Feb 12, 2026
48b199f
Add columns to the archive section
etagwerker Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/models/puzzle.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,11 @@ class Puzzle < ApplicationRecord
validates :question, presence: true

scope :archived, -> { where(state: :archived).order(sent_at: :desc) }

def correct_answer_percentage
total = answers.count
return 0 if total.zero?

(answers.where(is_correct: true).count * 100.0 / total).round(1)
end
end
8 changes: 5 additions & 3 deletions app/views/puzzles/_puzzles_table.html.erb
View file
Open in desktop
Copy link
Member

@fbuys fbuys Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can imaging that if the puzzle was cloned that we may want to know how many correct answers there were for the original question - but this number may be more suited to the Pending table.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
<th>Answer</th>
<th>Explanation</th>
<th>Link</th>
<% if actions == :archived %>
<% if actions.in?([:approved, :archived]) %>
<th>Correct %</th>
<th>Sent</th>
<% end %>
<th>Actions</th>
Expand All @@ -23,8 +24,9 @@
&nbsp;
<% end %>
</td>
<% if actions == :archived %>
<td><%= time_ago(puzzle.sent_at) %></td>
<% if actions.in?([:approved, :archived]) %>
<td><%= puzzle.correct_answer_percentage %>%</td>
<td><%= time_ago(puzzle.sent_at) if puzzle.sent_at.present? %></td>
<% end %>
<td>
<% if actions == :pending %>
Expand Down