Fix NotInvokedPrivateMethod lint warnings in FabricUIManager #55498
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mdvacca
force-pushed
the
export-D91992946
branch
2 times, most recently
from
1b32b80 to
7061a6f
Compare
Summary:
Fixed WrongConstant lint errors in ReactTextView.java by adding
SuppressLint("WrongConstant") annotation to the recycleView() method.
The Layout.BREAK_STRATEGY_* and Layout.JUSTIFICATION_MODE_* constants
have the same values as LineBreaker.* constants, but LineBreaker is only
available on API 29+ while React Native supports API 24+. The suppression
is safe since the constant values are identical.
changelog: [internal] internal
Differential Revision: D91990247
Summary:
Fixed SetLayoutParams lint errors in ReactTextView.java by adding
SuppressLint("SetLayoutParams") annotations.
The setLayoutParams calls are intentional:
1. In recycleView(): Resetting layout params when recycling the view
2. In setText(): Workaround for Android crash when LayoutParams is null
(see facebook#7011)
Both uses are safe because the view is about to have its layout params
set by the parent ViewGroup anyway.
changelog: [internal] internal
Differential Revision: D91990319
Summary:
Fixed ClassImplementsFinalize lint error in ReactRootView.java by adding
SuppressLint("ClassImplementsFinalize") annotation.
The finalize() method is used for memory leak detection during development.
It only performs an assertion check to warn developers when a ReactRootView
is garbage collected without being properly unmounted. Since it doesn't do
any actual cleanup (just an assertion), the typical finalize() risks
(performance degradation, deadlocks) don't apply here.
changelog: [internal] internal
Differential Revision: D91990367
Summary: Fixed NotInvokedPrivateMethod lint warning for unregisterFromInspector() by adding SuppressLint annotation. This is a native method that is called from C++ via JNI (registered in CatalystInstanceImpl.cpp). The lint tool doesn't understand JNI calls, so this is a false positive. changelog: [internal] internal Differential Revision: D91991480
Summary: Fixed NotInvokedPrivateMethod lint warnings for destroyUnmountedView() and scheduleMountItem() by adding SuppressLint annotations. These are private methods called from C++ via JNI (Binding.cpp). The lint tool doesn't understand JNI calls, so these are false positives. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91992946
mdvacca
force-pushed
the
export-D91992946
branch
from
7061a6f to
53553ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed NotInvokedPrivateMethod lint warnings for destroyUnmountedView() and
scheduleMountItem() by adding SuppressLint annotations.
These are private methods called from C++ via JNI (Binding.cpp). The lint
tool doesn't understand JNI calls, so these are false positives.
changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D91992946