Conversation
Rename it from "spit" to "spray". And move it to the first-party directory. Removing the previous license information. Also adjust the AnimationPlayer node in the enemy scene to delay a bit playing this sound effect, so it matches the frame-by-frame animation. The sound was recoded by @PlayMatters as InkDrinker_AirPop_01.wav and converted to OGG with ffmpeg. So attribution is Threadbare's Authors.
|
Play this branch at https://play.threadbare.game/branches/endlessm/ink-drinker-sfx. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
requested changes
Feb 24, 2026
Collaborator
Author
|
@wjt thanks for the feedback. Ready for review again! |
wjt
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename it from "spit" to "spray". And move it to the first-party directory. Removing the previous license information.
Also adjust the AnimationPlayer node in the enemy scene to delay a bit playing this sound effect, so it matches the frame-by-frame animation.
The sound was recoded by @PlayMatters as InkDrinker_AirPop_01.wav. So attribution is Threadbare's Authors.
There are unrelated changes in ink combat rounds 4, 5, 6 because of the recent projectile changes.