feat: upgrade React 16 to 18 #1852
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
felixrieseberg
force-pushed
the
felixr/enzyme-to-rtl-v2
branch
from
3194677 to
34c5ce5
Compare
Upgrade react/react-dom to ^18.3.1, react-mosaic-component to ^6.1.1, and @testing-library/react to ^16.1.0. Migrate ReactDOM.render() to createRoot(). Add Blueprint v3 type augmentations for React 18 children prop compatibility. Fix controlled input behavior in settings-electron.tsx and null-safe context access in output.tsx. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
felixrieseberg
force-pushed
the
felixr/react-18-upgrade
branch
from
62014e2 to
7b75eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade React from 16.14 to 18.3. Depends on #1851 (RTL migration).
Changes (10 files, +267 −231)
Dependencies
react/react-dom: ^16.14.0 → ^18.3.1react-mosaic-component: ^4.1.1 → ^6.1.1@testing-library/react: ^12.1.5 → ^16.1.0@types/react/@types/react-dom: → ^18.3.0@types/reactresolution to prevent duplicate type versionsSource changes
src/renderer/app.tsx:ReactDOM.render()→createRoot().render()src/renderer/components/settings-electron.tsx: Fix controlled checkbox (React 18 behavioral change)src/renderer/components/output.tsx: Null-safethis.context?.mosaicActionssrc/blueprint-react18.d.ts: Type augmentations for Blueprint v3childrenpropTest fixes (React 18 compat)
tests/renderer/app-spec.tsx: WrapcreateRootrender inact()rtl-spec/: AddwaitFor()for MobX observer batching,act()forsetState,blueprintNamespacein mosaic mockVerification
tsc --noEmit: 0 errorsvitest run: 91 files, 806 passedyarn start: builds and launches