Don't warn when JDK path from env var is not a directory#276
Draft
Don't warn when JDK path from env var is not a directory#276
Conversation
Copilot
AI
changed the title
[WIP] Fix ArgumentException during JDK validation
Don't warn when JDK path from env var is not a directory
Feb 20, 2026
When JI_JAVA_HOME (or another JDK path source) points to a path that exists but is not a directory, TryGetJdkInfo now checks Directory.Exists before constructing JdkInfo. Non-directory paths are skipped silently (logged at Verbose only) instead of generating a Warning in MSBuild output. Fixes: ArgumentException "Not a directory" spurious warning Co-authored-by: rmarinho <1235097+rmarinho@users.noreply.github.com>
731c702 to
07738c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
JI_JAVA_HOME(or other JDK path sources) points to a path that exists but is not a directory (e.g., a file or broken symlink),TryGetJdkInfowas propagating theArgumentExceptionfromJdkInfo..ctoras aTraceLevel.Warning, producing noisy, misleading output in MSBuild logs.Changes
JdkInfo.TryGetJdkInfo: Add an earlyDirectory.Existsguard. Paths that don't resolve to a directory are now silently skipped — logged only atVerbose— rather than emitting aWarning.GetKnownSystemJdkInfos_JiJavaHome_NonDirectoryPath_NoWarning: setsJI_JAVA_HOMEto a temp file path and asserts noWarningis logged.Original prompt
ArgumentExceptionlooking for JDKs #154💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.