-
Notifications
You must be signed in to change notification settings - Fork 8.2k
added manual for creating own DHI image #24075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Currently, working on a scenario that captures "Using OCI artifacts as package sources". |
Updated the title and linktitle for clarity, refined keywords, and added a section on building a catalog image. Adjusted descriptions for the os-release block and enhanced the examples for using OCI artifacts.
|
Ran vale and fixed few formatting issue. |
|
/review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation Review
Thank you for this comprehensive guide on building Docker Hardened Images! The content is well-structured and provides valuable information for users. I found a few minor clarity improvements that would enhance the documentation:
Summary
- ✅ Good technical accuracy and complete examples
- ✅ Clear step-by-step instructions
- ✅ Helpful YAML schema reference tables
- 💬 Minor terminology and clarity improvements suggested below
Note: Found 3 minor issues (1 confirmed, 2 likely improvements). The documentation is clear overall - these are small refinements for consistency with the style guide.
Updated the description of the DHI build process for clarity and accuracy.
craig-osterhout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial-wise, LGTM
Description
This PR adds a missing manual of building your own custom DHI image based on Alpine and Debian.
Related issues or tickets
Reviews