Enable .pgpass support for SSH tunnel connections#1546
Open
DiegoDAF wants to merge 1 commit intodbcli:mainfrom
Open
Enable .pgpass support for SSH tunnel connections#1546DiegoDAF wants to merge 1 commit intodbcli:mainfrom
DiegoDAF wants to merge 1 commit intodbcli:mainfrom
Conversation
j-bennet
reviewed
Dec 25, 2025
j-bennet
requested changes
Dec 25, 2025
Contributor
j-bennet
left a comment
There was a problem hiding this comment.
This needs test coverage before it can go in.
Preserve original hostname for .pgpass lookup using PostgreSQL's host/hostaddr parameters: host keeps the original DB hostname (for .pgpass and SSL), hostaddr gets 127.0.0.1 (the tunnel endpoint). Changes: - main.py: Use hostaddr instead of replacing host with 127.0.0.1 - main.py: Pass dsn in connect_uri() for proper .pgpass handling - pgexecute.py: Simplify DSN filtering to keep dsn, password, hostaddr - tests: Add 4 new tests, update existing to verify host preservation Made with ❤️ and 🤖 Claude
a67e7d8 to
a050131
Compare
Author
|
Addressed the feedback:
|
Contributor
|
Looks like there are test failures, take a look @DiegoDAF. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables PostgreSQL's
.pgpassfile to work seamlessly with SSH tunnel connections. Previously, when using--ssh-tunnel, the.pgpassfile was not consulted because pgcli was connecting to127.0.0.1instead of the original database hostname.Problem
When using SSH tunnels, the connection flow was:
--ssh-tunnel user@bastion --host production.db.com127.0.0.1:random_port→production.db.com:5432127.0.0.1:random_port.pgpasslookup fails (looking for127.0.0.1instead ofproduction.db.com)Solution
Use PostgreSQL's
host/hostaddrparameter separation:host: Original database hostname (for.pgpasslookup and SSL verification)hostaddr: Actual connection endpoint127.0.0.1(SSH tunnel local port)Changes
Core Functionality
connect()to preserve originalhostand usehostaddrfor tunnelconnect_uri()to pass DSN parameter for proper.pgpasshandlingpgexecute.pyto preservehostaddrwhen using DSN connectionsSSH Tunnel Enhancements
ssh_config_file: Use~/.ssh/configfor host settingsallow_agent: Enable SSH agent for authenticationcompression: False: Better performance for database connectionsBenefits
✅
.pgpassfile now works with SSH tunnels✅ No manual password entry needed
✅ Standard PostgreSQL authentication flow
✅ SSL certificate verification uses correct hostname
✅ Maintains all existing functionality
Example Usage
Technical Details
PostgreSQL supports both
hostandhostaddrparameters:hostis used for authentication (.pgpass, Kerberos, SSL CN)hostaddris used for the actual TCP connectionCompatibility
Made with ❤️ and 🤖 Claude Code