Remove size_on_disk from Table and Schema #1395
Open
+0
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Table.size_on_disk property - Remove Schema.size_on_disk property - Remove associated tests Rationale: - MySQL-specific queries (SHOW TABLE STATUS, information_schema) incompatible with PostgreSQL support - Incomplete picture in 2.0: reports only relational DB size, not object storage where large scientific data resides - MySQL statistics can be stale without ANALYZE TABLE - Trivial for users to implement directly if needed - Undocumented feature with limited utility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Table.size_on_diskpropertySchema.size_on_diskpropertyRationale
SHOW TABLE STATUSandinformation_schemaqueries incompatible with PostgreSQL supportANALYZE TABLETest plan
🤖 Generated with Claude Code