acc: add cleanup trap to postgres acceptance tests #4489

pietern · 2026-02-10T21:15:48Z

Summary

Add cleanup trap to ensure postgres branches and endpoints are destroyed after tests complete, preventing resource leaks.

Test plan

Run affected acceptance tests:

go test ./acceptance -run TestAccept/bundle/resources/postgres_branches/without_branch_id
go test ./acceptance -run TestAccept/bundle/resources/postgres_endpoints/without_endpoint_id

🤖 Generated with Claude Code

Add cleanup function with trap to ensure postgres branches and endpoints are destroyed after tests complete, preventing resource leaks. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

eng-dev-ecosystem-bot · 2026-02-10T21:39:55Z

Commit: 34eff8c

Run: 21898544808

	Env	❌FAIL	🟨KNOWN	🔄flaky	💚RECOVERED	🙈SKIP	✅pass	🙈skip	Time
💚	aws linux				8	7	451	731	20:18
🔄	aws windows			3	7	7	415	741	20:32
❌	aws-ucws linux	1	1	2	11	5	703	584	46:17
❌	aws-ucws windows	1	1	4	11	5	664	595	59:04
💚	azure linux				2	9	451	730	24:13
🔄	azure windows			3	1	9	415	740	19:33
🔄	azure-ucws linux			2	6	7	666	595	43:44
🔄	azure-ucws windows			5	5	7	627	606	39:36
💚	gcp linux				2	9	440	736	19:58
💚	gcp windows				2	9	406	746	17:24

34 interesting tests: 17 flaky, 10 RECOVERED, 5 SKIP, 1 KNOWN, 1 FAIL

	Test Name	aws linux	aws windows	aws-ucws linux	aws-ucws windows	azure linux	azure windows	azure-ucws linux	azure-ucws windows	gcp linux	gcp windows
🟨	TestAccept	💚R	🔄f	🟨K	🟨K	💚R	🔄f	💚R	💚R	💚R	💚R
🙈	TestAccept/bundle/deployment/bind/alert	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/deployment/bind/dashboard/recreation	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p
🔄	TestAccept/bundle/deployment/bind/dashboard/recreation/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p
🔄	TestAccept/bundle/deployment/bind/job/generate-and-bind	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p
🔄	TestAccept/bundle/deployment/bind/job/generate-and-bind/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p
🙈	TestAccept/bundle/generate/alert	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/invariant/no_drift	🙈S	🙈S	💚R	💚R	🙈S	🙈S	💚R	💚R	🙈S	🙈S
🙈	TestAccept/bundle/resources/alerts/basic	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/alerts/with_file	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/resources/apps/inline_config	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/jobs/fail-on-active-runs	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/jobs/fail-on-active-runs/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/models/basic/DATABRICKS_BUNDLE_ENGINE=direct	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/models/basic/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p
🙈	TestAccept/bundle/resources/permissions	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions	💚R	💚R	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct	💚R	💚R	💚R	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	💚R	💚R	💚R	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions	💚R	💚R	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct	💚R	💚R	💚R	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	💚R	💚R	💚R	💚R
❌	TestAccept/bundle/resources/postgres_endpoints/recreate	🙈s	🙈s	❌F	❌F	🙈s	🙈s	🙈s	🙈s	🙈s	🙈s
💚	TestAccept/bundle/resources/synced_database_tables/basic	🙈S	🙈S	💚R	💚R	🙈S	🙈S	💚R	💚R	🙈S	🙈S
💚	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct			💚R	💚R			💚R	💚R
💚	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform			💚R	💚R			💚R	💚R
🔄	TestAccept/bundle/templates/default-python/combinations/serverless	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=no/NBOOK=no/PY=yes/READPLAN=	🙈s	🙈s	🔄f	✅p	🙈s	🙈s	✅p	✅p	🙈s	🙈s
🔄	TestAccept/bundle/templates/default-python/integration_classic	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.9	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/ssh/connection	💚R	💚R	💚R	💚R	💚R	💚R	💚R	🔄f	💚R	💚R

Top 50 slowest tests (at least 2 minutes):

duration	env	testname
17:49	aws-ucws linux	TestAccept/ssh/connection
15:25	aws-ucws windows	TestAccept/ssh/connection
7:34	azure-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
7:20	aws-ucws windows	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
7:13	aws-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
7:08	aws-ucws linux	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
7:01	aws-ucws linux	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
7:00	azure linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
6:52	aws-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform
6:47	aws-ucws windows	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
6:36	aws-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
6:32	aws-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
6:32	aws-ucws linux	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
6:32	aws-ucws linux	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
6:30	gcp windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
6:20	azure-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
6:12	aws-ucws windows	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct
6:08	azure-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
6:06	azure-ucws windows	TestSecretsPutSecretStringValue
5:55	aws-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct
5:53	gcp linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:46	aws-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:40	aws-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:31	aws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:31	aws-ucws windows	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
5:29	aws-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:28	aws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:19	aws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:14	aws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:06	gcp windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:04	gcp linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:56	azure-ucws windows	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
4:55	azure-ucws linux	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
4:49	azure-ucws linux	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
4:49	azure-ucws windows	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct
4:28	azure-ucws linux	TestAccept/ssh/connection
4:24	azure-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
4:23	azure-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform
4:21	azure-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
4:18	azure-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:14	azure windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:13	gcp linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
4:08	azure linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:03	azure-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct
3:58	aws-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:57	aws-ucws windows	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform
3:52	aws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:50	azure-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
3:46	gcp linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:28	aws-ucws linux	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl

pietern · 2026-02-11T08:52:17Z

The tests that failed were fixed by #4483.

acc: add cleanup trap to postgres acceptance tests

06e0d36

Add cleanup function with trap to ensure postgres branches and endpoints are destroyed after tests complete, preventing resource leaks. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

pietern requested review from andrewnester, anton-107, denik and shreyas-goenka as code owners February 10, 2026 21:15

pietern temporarily deployed to test-trigger-is February 10, 2026 21:16 — with GitHub Actions Inactive

pietern enabled auto-merge February 10, 2026 21:17

pietern disabled auto-merge February 11, 2026 08:52

Merge branch 'main' into postgres-cleanup

34eff8c

pietern enabled auto-merge February 11, 2026 08:52

pietern temporarily deployed to test-trigger-is February 11, 2026 08:52 — with GitHub Actions Inactive

anton-107 approved these changes Feb 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

acc: add cleanup trap to postgres acceptance tests #4489

acc: add cleanup trap to postgres acceptance tests #4489

pietern commented Feb 10, 2026

Uh oh!

eng-dev-ecosystem-bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

pietern commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

acc: add cleanup trap to postgres acceptance tests #4489

Are you sure you want to change the base?

acc: add cleanup trap to postgres acceptance tests #4489

Conversation

pietern commented Feb 10, 2026

Summary

Test plan

Uh oh!

eng-dev-ecosystem-bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pietern commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eng-dev-ecosystem-bot commented Feb 10, 2026 •

edited

Loading