Added support for UC external locations (direct mode only) #4484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 0fd9a36
30 interesting tests: 12 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED, 1 FAIL
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Feb 11, 2026
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
Can you add config for invariant tests in acceptance/bundle/invariant?
denik
reviewed
Feb 11, 2026
| - field: storage_root | ||
| reason: immutable | ||
|
|
||
| external_locations: |
Contributor
There was a problem hiding this comment.
question - were you able to run 'make generate-direct' to update resources.generated.yml
Contributor
Author
There was a problem hiding this comment.
nope, it failed actually with
Traceback (most recent call last):
File "/Users/andrew.nester/cli/bundle/direct/tools/generate_resources.py", line 12, in <module>
import yaml
ModuleNotFoundError: No module named 'yaml'
which seems to be unrelated
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added support for UC external locations (direct mode only)
Why
This is a natural extension of support for UC catalogs where UC catalogs can have references to UC external locations.
Tests
Added an acceptance test