feat: use plugin manifest #4469
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
plugin-registry-integration
branch
from
93e4484 to
06f41ee
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 1677df6
32 interesting tests: 14 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED, 1 FAIL
Top 50 slowest tests (at least 2 minutes):
|
MarioCadenas
force-pushed
the
plugin-registry-integration
branch
from
06f41ee to
11fb319
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pkosiec
reviewed
Feb 11, 2026
Comment on lines
+105
to
+112
| # With database resource (both flags required together) | ||
| databricks apps init --name my-app --features=analytics \ | ||
| --warehouse-id=abc123 --database-instance=myinst --database-name=mydb | ||
|
|
||
| # With secret resource (both flags required together) | ||
| databricks apps init --name my-app --features=analytics \ | ||
| --warehouse-id=abc123 --secret-scope=myscope --secret-key=mykey | ||
|
|
Member
There was a problem hiding this comment.
So that means we cannot pass two secrets, is that correct?
IMO we should support such case - I can imagine that two plugins require separate secrets for them 🤔
Member
There was a problem hiding this comment.
To be honest I'm not a fan of defining the flags statically, if they are about providing dynamic arguments for a given template. And probably it is also limiting passing second secret (like in the comment before)
I'd suggest going with a dynamic approach - what do you think about doing what Helm (https://helm.sh/docs/helm/helm_install/) does: --set foo=bar? In that way we could provide multiple secrets, SQL warehouses, etc.
Even better, we could do --set analytics.warehouseId=foo - to avoid naming conflicts between plugins. Like:
--set analytics.lakebaseEndpoint=... --set myOwnPlugin.lakebaseEndpoint=...| } | ||
|
|
||
| // Remove analytics-specific files if analytics is not selected | ||
| if !selectedSet["analytics"] { |
Member
There was a problem hiding this comment.
This shouldn't be hardcoded anymore, right?
(we spoke about getting rid of hardcoded server, but this one should be also avoided; of course it doesn't need to be fixed on this PR 👍)
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests