feat(dash-spv-ffi): add dash_spv_ffi_client_broadcast_transaction FFI function#447
Draft
feat(dash-spv-ffi): add dash_spv_ffi_client_broadcast_transaction FFI function#447
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ZocoLini
force-pushed
the
feat/transaction-broadcasting-ffi
branch
2 times, most recently
from
a1d2ed4 to
beee4e8
Compare
All fields wrapped in `Arc` with locks. Callers hold a handle while the monitoring loop runs in a spawned task via `run()` getting rid of the command channel pattern.
…441) * fix: reset `FilterManager` when all peers disconnect - Override `stop_sync` in `FiltersManager` to clear the in-flight state when all peers disconnect. - Re-initialize the filter pipeline position in `start_sync` when filters are already at the stored tip preventing `extend_target` from re-queuing from height 1 after reconnecting. * Fix typo Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
ZocoLini
force-pushed
the
feat/transaction-broadcasting-ffi
branch
from
beee4e8 to
0e2b884
Compare
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
github-actions
bot
added
the
merge-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.