Improve workspace update confirmation to clarify restart consequence#792
Improve workspace update confirmation to clarify restart consequence#792
Conversation
src/commands.ts
Outdated
| useCustom: true, | ||
| modal: true, | ||
| detail: `Update ${createWorkspaceIdentifier(this.workspace)} to the latest version?\n\nUpdating will restart your workspace which stops any running processes and may result in the loss of unsaved work.`, | ||
| detail: `Updating ${createWorkspaceIdentifier(this.workspace)} to the latest template version will restart your workspace. Running processes will be stopped and unsaved work may be lost.`, |
There was a problem hiding this comment.
Let's keep the line break as it was, making it look cleaner.
There was a problem hiding this comment.
I suppose with the same (old) message then? So essentially we just change the action to indicate the restart (not ignorable)
There was a problem hiding this comment.
Yes, I think. That sounds good to me. Is it possible to make the button red, orange, or yellow?
There was a problem hiding this comment.
Sadly no, we cannot change this. Even they use info for deleting files (with the same 'ol themed button):
There was a problem hiding this comment.
Yeah I think it's better to reprompt, people tend to skim and not read the whole thing
Can we add another prompt?
I don't think renaming the button alone solves the pain point.
There was a problem hiding this comment.
We could do a follow up prompt yes, but see this comment: #784 (comment)
Essentially it would be a 3-step process instead of 2:
- Click "Update Workspace" on the statusbar OR Click "Update" on the notification OR execute "Update Workspace" command from the palette
- Get the modal above (currently we stop here)
- Ask for confirmation again
If we want to do the 3-step process, then what would we show differently to the modal on step (2)?
There was a problem hiding this comment.
yes. I think @sreya should help us here on what would be best. IMO, changing the button is sufficient, but it would be best to validate with the end user who reported it.
Let's merge this as it is with a renamed button, and we can consider a 3rd prompt in a follow-up if needed.
There was a problem hiding this comment.
Lets keep the issue open and update that we updated the button name
There was a problem hiding this comment.
Yeah I don't think a 3rd prompt would really achieve anything. I thought for some reason we weren't prompting the user after they clicked update. The rename is sufficient imo,
3 participants
Summary
Before:
After:
Updates #784