Skip to content

fix: install extensions under remote user not root user #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielleMaywood merged 1 commit into from
Feb 18, 2026
Merged

fix: install extensions under remote user not root user #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/code-server/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ VS Code in the browser ([code-server](https://github.com/coder/code-server))

---

_Note: This file was auto-generated from the [devcontainer-feature.json](https://github.com/coder/devcontainer-features/blob/main/src/code-server/devcontainer-feature.json). Add additional notes to a `NOTES.md`._
_Note: This file was auto-generated from the [devcontainer-feature.json](devcontainer-feature.json). Add additional notes to a `NOTES.md`._
15 changes: 10 additions & 5 deletions src/code-server/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,17 @@ fi

curl -fsSL https://code-server.dev/install.sh | sh -s -- $CODE_SERVER_INSTALL_ARGS

IFS=',' read -ra extensions <<<"$EXTENSIONS"
if [[ -n "$EXTENSIONS" ]]; then
IFS=',' read -ra extensions <<<"$EXTENSIONS"

for extension in "${extensions[@]}"
do
code-server --install-extension "$extension"
done
for extension in "${extensions[@]}"
do
if ! su "$_REMOTE_USER" -c "code-server --install-extension '$extension'"; then
echo "ERROR: Failed to install extension '$extension' as user '$_REMOTE_USER'" >&2
exit 1
fi
done
fi

CODE_SERVER_WORKSPACE="$_REMOTE_USER_HOME"

Expand Down
9 changes: 6 additions & 3 deletions test/code-server/code-server-extensions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@ check "code-server version" code-server --version
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
check "code-server listening" lsof -i "@0.0.0.0:8080"

extensions=$(sudo code-server --list-extensions)
# Verify extensions are installed under the remoteUser's home, not root's.
# See: https://github.com/coder/devcontainer-features/issues/18
extensions_dir=/home/vscode/.local/share/code-server/extensions

check "code-server extensions [rust-lang.rust-analyzer]" grep 'rust-lang.rust-analyzer\>' <<<"$extensions"
check "code-server extensions [ms-python.python]" grep 'ms-python.python\>' <<<"$extensions"
check "rust-analyzer installed under remoteUser" ls "$extensions_dir"/rust-lang.rust-analyzer-*
check "python installed under remoteUser" ls "$extensions_dir"/ms-python.python-*
check "extensions not installed under root" test ! -d /root/.local/share/code-server/extensions

# Report results
reportResults