chore(repo): remove backported changesets and backfill core-2 changelogs#7847
Open
jacekradko wants to merge 2 commits intomainfrom
Open
chore(repo): remove backported changesets and backfill core-2 changelogs#7847jacekradko wants to merge 2 commits intomainfrom
jacekradko wants to merge 2 commits intomainfrom
Conversation
Remove 33 changeset files that were already consumed by the core-2 release process to prevent duplicate changelog entries on the next core-3 release. Backfill 18 package CHANGELOGs with version entries published on core-2 that were missing from main.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughThis pull request performs a bulk release consolidation across the Clerk monorepo by removing approximately 35 pending changeset files and updating multiple package CHANGELOG.md files with new version entries. The changeset removals correspond to accumulated fixes, features, and dependency updates that have been consolidated into versioned releases (e.g., Possibly related PRs
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@packages/backend/CHANGELOG.md`:
- Around line 3-15: The changelog lists two functional changes (addition of
providerUserId on ExternalAccount and the new createBulk() method on
WaitlistEntryAPI), so verify whether corresponding behavior changes exist in
code and add/update tests accordingly: if ExternalAccount now exposes
providerUserId or deprecates externalId, add unit/integration tests for the
ExternalAccount model/serializers and any API endpoints that surface the field
(search for ExternalAccount and providerUserId); if
WaitlistEntryAPI.createBulk() was implemented, add tests covering bulk creation
success, validation/failure paths, and edge cases by locating the
WaitlistEntryAPI class and its createBulk method; finally, update test suites
and CI config to run the new tests and include references to the new tests in
the PR.
In `@packages/react-router/CHANGELOG.md`:
- Around line 3-12: The changelog release notes list dependency updates (e.g.,
`@clerk/shared`, `@clerk/backend`, `@clerk/clerk-react`, `@clerk/types`) but the PR
contains no tests; add or update automated tests that exercise the behavioral
changes introduced by these dependency bumps—identify the changed behaviors in
the code that depend on the updated packages (for example components/hooks in
the react-router package that integrate with `@clerk/clerk-react` or types from
`@clerk/types`), create unit/integration tests exercising those code paths, and
include them in the test suite so the release (2.4.4) is covered by tests before
merging.
jacekradko
changed the title
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainthat were already consumed by therelease/core-2release process, preventing duplicate changelog entries when core-3 releases@clerk/clerk-js5.114.1–5.123.0)Closes: USER-4423
Context
Commits were previously backported (cherry-picked) from
maintorelease/core-2, carrying their changeset files along. Core-2's release process consumed those changesets, but the same files still existed onmain. Without this cleanup, a core-3 release would consume them again, creating duplicate changelog entries.Additionally, core-2 published many versions that main's CHANGELOGs didn't include. These are now backfilled so the changelogs on main have a complete history.
Packages with backfilled CHANGELOGs (18)
agent-toolkit,astro,backend,chrome-extension,clerk-js,expo-passkeys,expo,express,fastify,localizations,nextjs,nuxt,react-router,react,shared,tanstack-react-start,testing,vueTest plan
pnpm buildpassesgit diff main --statshows only 33 changeset deletions + 18 CHANGELOG updates (51 files)Summary by CodeRabbit