fix: update-kind-example-to-containerd_1.5#1483
Open
dmitrynovik wants to merge 6 commits intocarvel-dev:developfrom
Open
fix: update-kind-example-to-containerd_1.5#1483dmitrynovik wants to merge 6 commits intocarvel-dev:developfrom
dmitrynovik wants to merge 6 commits intocarvel-dev:developfrom
Conversation
praveenrewar
approved these changes
Feb 14, 2024
aaa63b5 to
6174e8c
Compare
…troller-sidecarexec containers Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
…d. Add wait flags to pkg i pause. Signed-off-by: Soumik Majumder <soumikm@vmware.com> Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
column will be visible when --wide flag is set to true Signed-off-by: Premkumar Bhaskal <pbhaskal@gmail.com> Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
6174e8c to
c8e3018
Compare
Member
|
@dmitrynovik I think the rebase didn't work so there are some commits coming up from develop. Could you please take a look at it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adjusted the example of running the
kapp-controllerinkindfor thecontainerd 1.5+The example supplied in this repository, kapp-controller in kind, no longer works with my
containerd://1.7.1- the pods are scheduled and created, but there are image pull errors as every pod tries to pull image over HTTPS instead of HTTP ( as in this StackOverflow example).I believe this change happened in containerd v1.5 as each container needs a
hosts.tomlfile.This new requirement is also reflected in project kind: create a local registry, note a new step which is missing in the 2 year old kind-with-registry.sh script:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
NONE
-->
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: