Fix for Setting the custom properties value to null doesn't revert the value in SDM#420
Open
Fix for Setting the custom properties value to null doesn't revert the value in SDM#420
Conversation
Collaborator
Author
|
gemini review |
Collaborator
|
gemini review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added null check for secondary properties, so in case value is removed from UI then it will not include in builder request and remove from backend.
Type of change
Checklist before requesting a review
Single Tenant : https://github.com/cap-java/sdm/actions/runs/21616665799
Multi Tenant : https://github.com/cap-java/sdm/actions/runs/21624078165
Tested scenarios
1 - adding integer secondary type value and remove from attachment, changes reflected on backend
2 - adding date time secondary type value and remove from attachment, changes reflected on backend
3 - adding boolean secondary type value and remove from attachment, changes reflected on backend
4 - did above scenario with multiple attachment with different combinations.