validate heap_type in load_import_table_list #4827
Open
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylo5aby
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
kylo5aby
force-pushed
the
heap-type-check
branch
from
f9cd3b8 to
a355d9d
Compare
Signed-off-by: zhenweijin <zhenwei.jin@intel.com>
kylo5aby
force-pushed
the
heap-type-check
branch
2 times, most recently
from
80b1527 to
3547d18
Compare
Contributor
|
We usually assume that WASM files can be malformed, but AOT files are not. This is mostly because, in WAMR's security model, the AOT compiler is in the trusted zone. Therefore, I can hold off on this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add validation to ensure
heap_typeto be either a valid type index (0 <= heap_type < type_count) or a valid common heap type viawasm_is_valid_heap_type()