Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix failing “detail” tests by improving C++20 module support and refactoring detail customization/dispatch (completion signatures + impls lookup) to work in both header and module builds.
Changes:
- Adds many
*.cppmmodule wrapper units that re-export existing detail headers as modules. - Refactors several detail tag customizations to expose
get_completion_signatures()/impls_forvia tag types, and introduces aget_impls_for<Tag>dispatcher. - Updates numerous headers to use conditional
importvs#include, and adjusts examples/CMake for module builds.
Reviewed changes
Copilot reviewed 298 out of 413 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/beman/execution/set_value.cppm | Module wrapper exporting set_value symbols |
| src/beman/execution/set_stopped.cppm | Module wrapper exporting set_stopped symbols |
| src/beman/execution/set_error.cppm | Module wrapper exporting set_error symbols |
| src/beman/execution/sends_stopped.cppm | Module wrapper exporting sends_stopped symbols |
| src/beman/execution/sender_in.cppm | Module wrapper exporting sender_in symbols |
| src/beman/execution/sender_has_affine_on.cppm | Module wrapper exporting sender_has_affine_on symbols |
| src/beman/execution/sender_for.cppm | Module wrapper exporting sender_for symbols |
| src/beman/execution/sender_decompose.cppm | Module wrapper exporting sender decomposition helpers |
| src/beman/execution/sender_awaitable.cppm | Module wrapper exporting sender_awaitable symbols |
| src/beman/execution/sender_adaptor_closure.cppm | Module wrapper exporting adaptor-closure & pipe operator |
| src/beman/execution/sender_adaptor.cppm | Module wrapper exporting sender_adaptor symbols |
| src/beman/execution/sender.cppm | Module wrapper exporting sender concepts/types |
| src/beman/execution/scope_token.cppm | Module wrapper exporting scope_token symbols |
| src/beman/execution/scheduler_t.cppm | Module wrapper exporting scheduler_t symbols |
| src/beman/execution/scheduler.cppm | Module wrapper exporting scheduler symbols |
| src/beman/execution/schedule_result_t.cppm | Module wrapper exporting schedule_result_t symbols |
| src/beman/execution/schedule_from.cppm | Module wrapper exporting schedule_from symbols |
| src/beman/execution/schedule.cppm | Module wrapper exporting schedule symbols |
| src/beman/execution/sched_env.cppm | Module wrapper exporting sched_env symbols |
| src/beman/execution/sched_attrs.cppm | Module wrapper exporting sched_attrs symbols |
| src/beman/execution/run_loop.cppm | Module wrapper exporting run_loop symbols |
| src/beman/execution/receiver_of.cppm | Module wrapper exporting receiver_of symbols |
| src/beman/execution/receiver.cppm | Module wrapper exporting receiver concepts/types |
| src/beman/execution/read_env.cppm | Module wrapper exporting read_env symbols |
| src/beman/execution/queryable.cppm | Module wrapper exporting queryable symbols |
| src/beman/execution/query_with_default.cppm | Module wrapper exporting query_with_default symbols |
| src/beman/execution/prop.cppm | Module wrapper exporting prop symbols |
| src/beman/execution/product_type.cppm | Module wrapper exporting product_type + MSVC tuple traits |
| src/beman/execution/operation_state_task.cppm | Module wrapper exporting operation state task helpers |
| src/beman/execution/operation_state.cppm | Module wrapper exporting operation_state symbols |
| src/beman/execution/on_stop_request.cppm | Module wrapper exporting on_stop_request symbols |
| src/beman/execution/on.cppm | Module wrapper exporting on symbols |
| src/beman/execution/notify.cppm | Module wrapper exporting notify symbols |
| src/beman/execution/nothrow_callable.cppm | Module wrapper exporting nothrow_callable symbols |
| src/beman/execution/nostopstate.cppm | Module wrapper exporting nostopstate symbols |
| src/beman/execution/non_assignable.cppm | Module wrapper exporting non_assignable symbols |
| src/beman/execution/never_stop_token.cppm | Module wrapper exporting never_stop_token symbols |
| src/beman/execution/nested_sender_has_affine_on.cppm | Module wrapper exporting nested sender affine helper |
| src/beman/execution/movable_value.cppm | Module wrapper exporting movable_value symbols |
| src/beman/execution/meta_unique.cppm | Module wrapper exporting meta::unique |
| src/beman/execution/meta_transform.cppm | Module wrapper exporting meta::transform |
| src/beman/execution/meta_to.cppm | Module wrapper exporting meta::to |
| src/beman/execution/meta_size.cppm | Module wrapper exporting meta::size |
| src/beman/execution/meta_prepend.cppm | Module wrapper exporting meta::prepend |
| src/beman/execution/meta_filter.cppm | Module wrapper exporting meta::filter |
| src/beman/execution/meta_contains.cppm | Module wrapper exporting meta::contains |
| src/beman/execution/meta_contain_same.cppm | Module wrapper exporting meta::contain_same |
| src/beman/execution/meta_combine.cppm | Module wrapper exporting meta::combine |
| src/beman/execution/matching_sig.cppm | Module wrapper exporting matching_sig |
| src/beman/execution/make_sender.cppm | Module wrapper exporting make_sender |
| src/beman/execution/make_env.cppm | Module wrapper exporting make_env |
| src/beman/execution/let.cppm | Module wrapper exporting let_* symbols |
| src/beman/execution/just.cppm | Module wrapper exporting just* symbols |
| src/beman/execution/join_env.cppm | Module wrapper exporting join_env |
| src/beman/execution/is_awaiter.cppm | Module wrapper exporting is_awaiter |
| src/beman/execution/is_awaitable.cppm | Module wrapper exporting is_awaitable |
| src/beman/execution/intrusive_stack.cppm | Module wrapper exporting intrusive_stack |
| src/beman/execution/into_variant.cppm | Module wrapper exporting into_variant |
| src/beman/execution/inplace_stop_source.cppm | Module wrapper exporting inplace_stop_source |
| src/beman/execution/indirect_meta_apply.cppm | Module wrapper exporting indirect_meta_apply |
| src/beman/execution/indices_for.cppm | Module wrapper exporting indices_for |
| src/beman/execution/impls_for.cppm | Module wrapper exporting impls_for |
| src/beman/execution/immovable.cppm | Module wrapper exporting immovable types |
| src/beman/execution/has_completions.cppm | Module wrapper exporting has_completions |
| src/beman/execution/has_as_awaitable.cppm | Module wrapper exporting has_as_awaitable |
| src/beman/execution/get_stop_token.cppm | Module wrapper exporting get_stop_token |
| src/beman/execution/get_scheduler.cppm | Module wrapper exporting get_scheduler |
| src/beman/execution/get_env.cppm | Module wrapper exporting get_env |
| src/beman/execution/get_domain_late.cppm | Module wrapper exporting get_domain_late |
| src/beman/execution/get_domain_early.cppm | Module wrapper exporting get_domain_early |
| src/beman/execution/get_domain.cppm | Module wrapper exporting get_domain |
| src/beman/execution/get_delegation_scheduler.cppm | Module wrapper exporting get_delegation_scheduler |
| src/beman/execution/get_completion_signatures.cppm | Module wrapper exporting get_completion_signatures |
| src/beman/execution/get_completion_scheduler.cppm | Module wrapper exporting get_completion_scheduler |
| src/beman/execution/get_awaiter.cppm | Module wrapper exporting get_awaiter |
| src/beman/execution/get_allocator.cppm | Module wrapper exporting get_allocator |
| src/beman/execution/gather_signatures.cppm | Module wrapper exporting gather_signatures |
| src/beman/execution/fwd_env.cppm | Module wrapper exporting fwd_env |
| src/beman/execution/forwarding_query.cppm | Module wrapper exporting forwarding_query |
| src/beman/execution/forward_like.cppm | Module wrapper exporting forward_like |
| src/beman/execution/execution-detail.cppm | Aggregating module re-exporting many detail modules |
| src/beman/execution/error_types_of_t.cppm | Module wrapper exporting error_types_of_t |
| src/beman/execution/env_type.cppm | Module wrapper exporting env_type |
| src/beman/execution/env_promise.cppm | Module wrapper exporting env_promise |
| src/beman/execution/env_of_t.cppm | Module wrapper exporting env_of_t |
| src/beman/execution/env.cppm | Module wrapper exporting env |
| src/beman/execution/emplace_from.cppm | Module wrapper exporting emplace_from |
| src/beman/execution/default_impls.cppm | Module wrapper exporting default_impls |
| src/beman/execution/default_domain.cppm | Module wrapper exporting default_domain |
| src/beman/execution/decays_to.cppm | Module wrapper exporting decays_to |
| src/beman/execution/decayed_typeof.cppm | Module wrapper exporting decayed_typeof |
| src/beman/execution/decayed_type_list.cppm | Module wrapper exporting decayed_type_list |
| src/beman/execution/decayed_tuple.cppm | Module wrapper exporting decayed_tuple |
| src/beman/execution/decayed_same_as.cppm | Module wrapper exporting decayed_same_as |
| src/beman/execution/counting_scope_join.cppm | Module wrapper exporting counting-scope join |
| src/beman/execution/counting_scope_base.cppm | Module wrapper exporting counting-scope base |
| src/beman/execution/counting_scope.cppm | Module wrapper exporting counting-scope |
| src/beman/execution/continues_on.cppm | Module wrapper + exported get_domain_late implementation |
| src/beman/execution/connect_result_t.cppm | Module wrapper exporting connect_result_t |
| src/beman/execution/connect_awaitable.cppm | Module wrapper exporting connect_awaitable |
| src/beman/execution/connect_all_result.cppm | Module wrapper exporting connect_all_result |
| src/beman/execution/connect_all.cppm | Module wrapper exporting connect_all |
| src/beman/execution/connect.cppm | Module wrapper exporting connect |
| src/beman/execution/completion_tag.cppm | Module wrapper exporting completion_tag |
| src/beman/execution/completion_signatures_of_t.cppm | Module wrapper exporting completion_signatures_of_t |
| src/beman/execution/completion_signatures_for.cppm | Module wrapper exporting completion_signatures_for |
| src/beman/execution/completion_signatures.cppm | Module wrapper exporting completion_signatures |
| src/beman/execution/completion_signature.cppm | Module wrapper exporting completion_signature |
| src/beman/execution/completion_domain.cppm | Module wrapper exporting completion_domain |
| src/beman/execution/class_type.cppm | Module wrapper exporting class_type |
| src/beman/execution/child_type.cppm | Module wrapper exporting child_type |
| src/beman/execution/check_type_alias_exist.cppm | Module wrapper exporting check_type_alias_exist |
| src/beman/execution/callable.cppm | Module wrapper exporting callable |
| src/beman/execution/call_result_t.cppm | Module wrapper exporting call_result_t |
| src/beman/execution/bulk.cppm | Module wrapper exporting bulk |
| src/beman/execution/basic_state.cppm | Module wrapper exporting basic_state |
| src/beman/execution/basic_sender.cppm | Module wrapper exporting basic_sender + MSVC tuple traits |
| src/beman/execution/basic_receiver.cppm | Module wrapper exporting basic_receiver |
| src/beman/execution/basic_operation.cppm | Module wrapper exporting basic_operation |
| src/beman/execution/awaitable_sender.cppm | Module wrapper exporting awaitable_sender |
| src/beman/execution/await_suspend_result.cppm | Module wrapper exporting await_suspend_result |
| src/beman/execution/await_result_type.cppm | Module wrapper exporting await_result_type |
| src/beman/execution/atomic_intrusive_stack.cppm | Module wrapper exporting atomic_intrusive_stack |
| src/beman/execution/associate.cppm | Module wrapper exporting associate symbols |
| src/beman/execution/as_tuple.cppm | Module wrapper exporting as_tuple |
| src/beman/execution/as_except_ptr.cppm | Module wrapper exporting as_except_ptr |
| src/beman/execution/as_awaitable.cppm | Module wrapper exporting as_awaitable |
| src/beman/execution/apply_sender.cppm | Module wrapper exporting apply_sender |
| src/beman/execution/almost_scheduler.cppm | Module wrapper exporting almost_scheduler |
| src/beman/execution/allocator_aware_move.cppm | Module wrapper exporting allocator_aware_move |
| src/beman/execution/affine_on.cppm | Module wrapper exporting affine_on |
| include/beman/execution26/execution.hpp | Removes execution26 detail aliases for write_env |
| include/beman/execution/stop_token.hpp | Adds module-aware imports for stop-token components |
| include/beman/execution/functional.hpp | Adds module-aware imports/includes for functional traits |
| include/beman/execution/detail/write_env.hpp | Refactors write_env_t customizations & module imports |
| include/beman/execution/detail/with_awaitable_senders.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/with_await_transform.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/when_all_with_variant.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/variant_or_empty.hpp | Switches to module import for meta.unique when available |
| include/beman/execution/detail/value_types_of_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/valid_completion_signatures.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/valid_completion_for.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/unstoppable_token.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/unspecified_promise.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/transform_sender.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/tag_of_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sync_wait.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/suspend_complete.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/suppress_push.hpp | Adds common.hpp include |
| include/beman/execution/detail/suppress_pop.hpp | Adds common.hpp include |
| include/beman/execution/detail/stoppable_token.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/stoppable_source.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/stop_when.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/stop_token_of_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/stop_source.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/stop_callback_for_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/state_type.hpp | Switches to get_impls_for indirection |
| include/beman/execution/detail/starts_on.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/start.hpp | Minor include cleanup |
| include/beman/execution/detail/split.hpp | Refactors completion signatures plumbing & impls shape |
| include/beman/execution/detail/spawn_get_allocator.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/spawn_future.hpp | Refactors tag customizations + module-aware imports |
| include/beman/execution/detail/spawn.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/single_sender_value_type.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/single_sender.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/simple_counting_scope.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/simple_allocator.hpp | Adds module-aware imports/includes and comment cleanup |
| include/beman/execution/detail/set_value.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/set_stopped.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/set_error.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/sends_stopped.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sender_in.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sender_has_affine_on.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sender_for.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sender_decompose.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/sender_awaitable.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sender_adaptor_closure.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sender_adaptor.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sender.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/scope_token.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/scheduler.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/schedule_result_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/schedule.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sched_env.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/sched_attrs.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/run_loop.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/receiver_of.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/receiver.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/read_env.hpp | Refactors signatures plumbing + module-aware imports |
| include/beman/execution/detail/queryable.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/query_with_default.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/prop.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/product_type.hpp | Adjusts tuple traits specializations & noexcept |
| include/beman/execution/detail/operation_state_task.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/operation_state.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/on.hpp | Adds module-aware imports/includes and refactors bindings |
| include/beman/execution/detail/notify.hpp | Refactors tag customization + module-aware imports |
| include/beman/execution/detail/nothrow_callable.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/nested_sender_has_affine_on.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/movable_value.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/meta_unique.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/meta_transform.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/meta_size.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/meta_filter.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/meta_contains.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/meta_contain_same.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/meta_combine.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/matching_sig.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/make_sender.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/make_env.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/just.hpp | Refactors tag customization + module-aware imports |
| include/beman/execution/detail/join_env.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/is_awaiter.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/is_awaitable.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/intrusive_stack.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/inplace_stop_source.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/indices_for.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/impls_for.hpp | Adds get_impls_for<Tag> indirection |
| include/beman/execution/detail/has_completions.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/has_as_awaitable.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_stop_token.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_scheduler.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_env.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_domain_late.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_domain_early.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_domain.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_delegation_scheduler.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_completion_signatures.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_completion_scheduler.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/get_awaiter.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/get_allocator.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/gather_signatures.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/fwd_env.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/forwarding_query.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/forward_like.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/error_types_of_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/env_type.hpp | Switches to get_impls_for indirection + module imports |
| include/beman/execution/detail/env_promise.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/env_of_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/env.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/emplace_from.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/default_impls.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/default_domain.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/decays_to.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/decayed_typeof.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/decayed_type_list.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/decayed_tuple.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/decayed_same_as.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/counting_scope_join.hpp | Refactors tag customization + module-aware imports |
| include/beman/execution/detail/counting_scope_base.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/counting_scope.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/continues_on.hpp | Refactors tag customization + module-aware imports |
| include/beman/execution/detail/connect_result_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/connect_awaitable.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/connect_all_result.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/connect_all.hpp | Adds tuple-size helper, module-aware imports/includes |
| include/beman/execution/detail/connect.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/completion_tag.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/completion_signatures_of_t.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/completion_signatures_for.hpp | Refactors completion signatures lookup to consteval helper |
| include/beman/execution/detail/completion_signatures.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/completion_signature.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/completion_domain.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/common.hpp | Adds BEMAN_SPECIALIZE_EXPORT macro |
| include/beman/execution/detail/class_type.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/child_type.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/callable.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/call_result_t.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/basic_state.hpp | Switches to get_impls_for indirection + module imports |
| include/beman/execution/detail/basic_receiver.hpp | Switches to get_impls_for indirection + module imports |
| include/beman/execution/detail/basic_operation.hpp | Switches to get_impls_for indirection + module imports |
| include/beman/execution/detail/awaitable_sender.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/await_suspend_result.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/await_result_type.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/atomic_intrusive_stack.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/associate.hpp | Refactors tag customization + module-aware imports (adds debug output) |
| include/beman/execution/detail/as_tuple.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/as_except_ptr.hpp | Adds module-aware std import/include |
| include/beman/execution/detail/as_awaitable.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/apply_sender.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/almost_scheduler.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/allocator_aware_move.hpp | Adds module-aware imports/includes |
| include/beman/execution/detail/affine_on.hpp | Adds module-aware imports/includes and refactors bindings |
| examples/sender-demo.cpp | Imports detail module in module builds |
| examples/modules.cpp | Simplifies to module-only import path |
| examples/just_stopped.cpp | Adds conditional module import |
| examples/intro-5-consumer.cpp | Imports detail module in module builds |
| examples/CMakeLists.txt | Adjusts module build flags for examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ClausKlein
reviewed
Feb 13, 2026
ClausKlein
reviewed
Feb 13, 2026
ClausKlein
reviewed
Feb 13, 2026
Comment on lines
+370
to
371
| target_compile_definitions(beman.execution PUBLIC BEMAN_HAS_MODULES) | ||
| target_link_libraries(${TARGET_PREFIX} PUBLIC ${TARGET_NAME}) |
Collaborator
There was a problem hiding this comment.
we should use TARGET_PREFIX variable or the real target name at all places to be consistent.
dietmarkuehl
force-pushed
the
fix-detail-tests
branch
from
02185b4 to
d6358b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.