test: prevent storage directory leak from randomized env vars test#779
Merged
test: prevent storage directory leak from randomized env vars test#779
Conversation
The test_get_env_with_randomized_env_vars test was overriding APIFY_LOCAL_STORAGE_DIR with a random 10-char string, causing Actor.init() to create a storage directory in the project root. Exclude LOCAL_STORAGE_DIR from randomization and use the tmp_path value set by the _isolate_test_environment fixture instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
===========================================
- Coverage 81.86% 68.02% -13.84%
===========================================
Files 46 46
Lines 2696 2696
===========================================
- Hits 2207 1834 -373
- Misses 489 862 +373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_get_env_with_randomized_env_varswas overridingAPIFY_LOCAL_STORAGE_DIRwith a random 10-char string (e.g.KAHL8QER2W), causingActor.init()to create a leftover storage directory in the project root on every test runLOCAL_STORAGE_DIRfrom randomization and set the expected value to thetmp_pathprovided by the_isolate_test_environmentfixtureTest plan
uv run poe lintpassesuv run poe unit-testspasses (249 tests)🤖 Generated with Claude Code