SOLR-18108: remove deprecated method from AuditEvent#4143
Open
epugh wants to merge 2 commits intoapache:mainfrom
Open
SOLR-18108: remove deprecated method from AuditEvent#4143epugh wants to merge 2 commits intoapache:mainfrom
epugh wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
The method |
Contributor
Author
|
tests pass..... I'll leave this open for a few days to find out about the unused methods and then merge. |
Contributor
Author
|
@hossman you may know about these additional methods that aren't used inside of Solr? |
Member
|
I don't think i've ever even seen this class before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18108
Description
Remove deprecated method.
However, there are a large number of unused methods in this like:
@janhoy you have familiarity I think with this class, can we remove the methods that have no callers? Or do they exist for a class outside of Solr to interact with?
Solution
Reviewing the code.
Tests
Existing