Skip to content

Comments

SOLR-18108: remove deprecated method from AuditEvent#4143

Open
epugh wants to merge 2 commits intoapache:mainfrom
epugh:SOLR-18108
Open

SOLR-18108: remove deprecated method from AuditEvent#4143
epugh wants to merge 2 commits intoapache:mainfrom
epugh:SOLR-18108

Conversation

@epugh
Copy link
Contributor

@epugh epugh commented Feb 18, 2026

https://issues.apache.org/jira/browse/SOLR-18108

Description

Remove deprecated method.

However, there are a large number of unused methods in this like:

  public AuditEvent setSolrPort(int solrPort) {
    this.solrPort = solrPort;
    return this;
  }

@janhoy you have familiarity I think with this class, can we remove the methods that have no callers? Or do they exist for a class outside of Solr to interact with?

Solution

Reviewing the code.

Tests

Existing

@epugh
Copy link
Contributor Author

epugh commented Feb 18, 2026

The method setAutResponse looks like it's misspelled? setAuthResponse? However it's not called.

@epugh
Copy link
Contributor Author

epugh commented Feb 18, 2026

tests pass..... I'll leave this open for a few days to find out about the unused methods and then merge.

@epugh epugh requested a review from dsmiley February 20, 2026 15:12
@epugh
Copy link
Contributor Author

epugh commented Feb 20, 2026

@hossman you may know about these additional methods that aren't used inside of Solr?

@hossman
Copy link
Member

hossman commented Feb 20, 2026

I don't think i've ever even seen this class before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants