SOLR-18103: Remove deprecated solr.xml <metrics><hiddenSysProps></metrics> #4136
Open
epugh wants to merge 4 commits intoapache:mainfrom
Open
SOLR-18103: Remove deprecated solr.xml <metrics><hiddenSysProps></metrics> #4136epugh wants to merge 4 commits intoapache:mainfrom
epugh wants to merge 4 commits intoapache:mainfrom
Conversation
Modify ReplicationHandler backup and deletebackup commands to use the proper constructors. Opens the door to these commands being used in the future with non filesystem backup Repos.
This reverts commit 6329185.
Contributor
Author
|
Unit tests all passed locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18103
Description
Remove deprecated code.
<metrics><hiddenSysProps></metrics>is no longer supported, but<solr><hiddenSysProps></solr>is.Solution
remove and run tests
Tests
Existing