RATIS-2407. Missing return statement after stream closed check in OrderedRequestStreamObserver.#1348
Merged
szetszwo merged 1 commit intoapache:masterfrom Feb 14, 2026
Merged
Conversation
…eredRequestStreamObserver.
szetszwo
approved these changes
Feb 14, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
@szetszwo Thank you very much for reviewing the code! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Expected Behavior
After detecting the stream is closed and reporting the error, the method should return immediately to avoid:
Solution
Add a
returnstatement after theresponseError()call at line 340.The same method already has correct error handling for group mismatch at line ~354, which includes a
returnstatement after callingresponseError(). The stream-closed check should follow the same pattern.What is the link to the Apache JIRA
JIRA: RATIS-2407. Missing return statement after stream closed check in OrderedRequestStreamObserver.
How was this patch tested?
unit tests.