GH-3399: Hint IDE the source code generated by thrift#3400
Open
HuaHuaY wants to merge 1 commit intoapache:masterfrom
Open
GH-3399: Hint IDE the source code generated by thrift#3400HuaHuaY wants to merge 1 commit intoapache:masterfrom
HuaHuaY wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves IDE/Maven project source-root recognition for Thrift-generated Java code, preventing IDE errors like unresolved org.apache.parquet.* imports in generated sources.
Changes:
- Add
build-helper-maven-pluginto registertarget/generated-sources/thriftas a compile source root inparquet-format-structures. - Add
build-helper-maven-pluginto registertarget/generated-test-sources/thriftas a test source root inparquet-thrift.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| parquet-thrift/pom.xml | Adds generated Thrift test sources directory to Maven test source roots for IDE/build visibility. |
| parquet-format-structures/pom.xml | Adds generated Thrift main sources directory to Maven compile source roots for IDE/build visibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Hint IDE the source code generated by thrift so it will not report
The import org.apache.parquet.xxxxxx cannot be resolvedWhat changes are included in this PR?
Modified two pom.xml files and added
build-helper-maven-pluginplugin.Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Closes #3399